You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/09 15:54:22 UTC

[GitHub] [dubbo-go] AlbumenJ opened a new pull request #591: Fix: Nacos client logDir path seperator

AlbumenJ opened a new pull request #591:
URL: https://github.com/apache/dubbo-go/pull/591


   **What this PR does**:
   
   - fix logDir path seperator in Windows
   - fix unit test prepare script for Windows
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes #
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   no


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #591: Fix: Nacos client logDir path seperator

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #591:
URL: https://github.com/apache/dubbo-go/pull/591#issuecomment-640994669


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=h1) Report
   > Merging [#591](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/106040d53d8e0f799615fd3f4796fb2c9008d9fc&el=desc) will **increase** coverage by `0.59%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/591/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #591      +/-   ##
   ===========================================
   + Coverage    66.80%   67.39%   +0.59%     
   ===========================================
     Files          185      188       +3     
     Lines         9749     9858     +109     
   ===========================================
   + Hits          6513     6644     +131     
   + Misses        2600     2560      -40     
   - Partials       636      654      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `74.79% <66.66%> (+19.24%)` | :arrow_up: |
   | [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `56.81% <0.00%> (-9.10%)` | :arrow_down: |
   | [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
   | [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `70.83% <0.00%> (-1.64%)` | :arrow_down: |
   | [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
   | [cluster/cluster\_impl/failover\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbG92ZXJfY2x1c3Rlcl9pbnZva2VyLmdv) | `71.15% <0.00%> (-1.19%)` | :arrow_down: |
   | [cluster/cluster\_impl/forking\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZm9ya2luZ19jbHVzdGVyX2ludm9rZXIuZ28=) | `58.33% <0.00%> (-0.21%)` | :arrow_down: |
   | [filter/filter\_impl/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvc2lnbl91dGlsLmdv) | `69.23% <0.00%> (ø)` | |
   | [filter/filter\_impl/auth/consumer\_sign.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvY29uc3VtZXJfc2lnbi5nbw==) | `60.00% <0.00%> (ø)` | |
   | [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <0.00%> (ø)` | |
   | ... and [16 more](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=footer). Last update [106040d...79abeed](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #591: Fix: Nacos client logDir path seperator

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #591:
URL: https://github.com/apache/dubbo-go/pull/591


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlbumenJ commented on a change in pull request #591: Fix: Nacos client logDir path seperator

Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on a change in pull request #591:
URL: https://github.com/apache/dubbo-go/pull/591#discussion_r437845858



##########
File path: config_center/nacos/client.go
##########
@@ -50,6 +51,16 @@ type NacosClient struct {
 	onceClose  func()
 }
 
+// init default Nacos Log dir, it can be override when create client
+func init() {
+	switch runtime.GOOS {
+	case "windows":
+		logDir = "logs\\nacos\\log"
+	default:
+		logDir = "logs/nacos/log"
+	}

Review comment:
       thx, I have changed it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter commented on pull request #591: Fix: Nacos client logDir path seperator

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #591:
URL: https://github.com/apache/dubbo-go/pull/591#issuecomment-640994669


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=h1) Report
   > Merging [#591](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/106040d53d8e0f799615fd3f4796fb2c9008d9fc&el=desc) will **increase** coverage by `0.59%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/591/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #591      +/-   ##
   ===========================================
   + Coverage    66.80%   67.39%   +0.59%     
   ===========================================
     Files          185      188       +3     
     Lines         9749     9858     +109     
   ===========================================
   + Hits          6513     6644     +131     
   + Misses        2600     2560      -40     
   - Partials       636      654      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `74.79% <66.66%> (+19.24%)` | :arrow_up: |
   | [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `56.81% <0.00%> (-9.10%)` | :arrow_down: |
   | [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
   | [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `70.83% <0.00%> (-1.64%)` | :arrow_down: |
   | [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
   | [cluster/cluster\_impl/failover\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbG92ZXJfY2x1c3Rlcl9pbnZva2VyLmdv) | `71.15% <0.00%> (-1.19%)` | :arrow_down: |
   | [cluster/cluster\_impl/forking\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZm9ya2luZ19jbHVzdGVyX2ludm9rZXIuZ28=) | `58.33% <0.00%> (-0.21%)` | :arrow_down: |
   | [filter/filter\_impl/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvc2lnbl91dGlsLmdv) | `69.23% <0.00%> (ø)` | |
   | [filter/filter\_impl/auth/consumer\_sign.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvY29uc3VtZXJfc2lnbi5nbw==) | `60.00% <0.00%> (ø)` | |
   | [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <0.00%> (ø)` | |
   | ... and [16 more](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=footer). Last update [106040d...2f1c219](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] Patrick0308 commented on a change in pull request #591: Fix: Nacos client logDir path seperator

Posted by GitBox <gi...@apache.org>.
Patrick0308 commented on a change in pull request #591:
URL: https://github.com/apache/dubbo-go/pull/591#discussion_r437841774



##########
File path: config_center/nacos/client.go
##########
@@ -50,6 +51,16 @@ type NacosClient struct {
 	onceClose  func()
 }
 
+// init default Nacos Log dir, it can be override when create client
+func init() {
+	switch runtime.GOOS {
+	case "windows":
+		logDir = "logs\\nacos\\log"
+	default:
+		logDir = "logs/nacos/log"
+	}

Review comment:
       ```suggestion
   	logDir = filepath.Join("logs", "nacos", "log")
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #591: Fix: Nacos client logDir path seperator

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #591:
URL: https://github.com/apache/dubbo-go/pull/591#issuecomment-640994669


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=h1) Report
   > Merging [#591](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/106040d53d8e0f799615fd3f4796fb2c9008d9fc&el=desc) will **increase** coverage by `0.48%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/591/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #591      +/-   ##
   ===========================================
   + Coverage    66.80%   67.29%   +0.48%     
   ===========================================
     Files          185      188       +3     
     Lines         9749     9854     +105     
   ===========================================
   + Hits          6513     6631     +118     
   + Misses        2600     2574      -26     
   - Partials       636      649      +13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `73.33% <100.00%> (+1.90%)` | :arrow_up: |
   | [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `75.42% <100.00%> (+19.86%)` | :arrow_up: |
   | [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <0.00%> (-11.36%)` | :arrow_down: |
   | [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `56.81% <0.00%> (-9.10%)` | :arrow_down: |
   | [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
   | [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `76.81% <0.00%> (-4.55%)` | :arrow_down: |
   | [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
   | [cluster/cluster\_impl/failover\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbG92ZXJfY2x1c3Rlcl9pbnZva2VyLmdv) | `71.15% <0.00%> (-1.19%)` | :arrow_down: |
   | [cluster/cluster\_impl/forking\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZm9ya2luZ19jbHVzdGVyX2ludm9rZXIuZ28=) | `58.33% <0.00%> (-0.21%)` | :arrow_down: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (ø)` | |
   | ... and [22 more](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=footer). Last update [106040d...79abeed](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlbumenJ commented on a change in pull request #591: Fix: Nacos client logDir path seperator

Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on a change in pull request #591:
URL: https://github.com/apache/dubbo-go/pull/591#discussion_r437206540



##########
File path: config_center/nacos/client.go
##########
@@ -50,6 +51,15 @@ type NacosClient struct {
 	onceClose  func()
 }
 
+func init() {
+	switch runtime.GOOS {
+	case "windows":
+		logDir = "logs\\nacos\\log"
+	default:
+		logDir = "logs/nacos/log"
+	}
+}
+

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on a change in pull request #591: Fix: Nacos client logDir path seperator

Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #591:
URL: https://github.com/apache/dubbo-go/pull/591#discussion_r437107907



##########
File path: config_center/nacos/client.go
##########
@@ -50,6 +51,15 @@ type NacosClient struct {
 	onceClose  func()
 }
 
+func init() {
+	switch runtime.GOOS {
+	case "windows":
+		logDir = "logs\\nacos\\log"
+	default:
+		logDir = "logs/nacos/log"
+	}
+}
+

Review comment:
       Inaddition to set default value for `logDir`, we should provide a config item to change this value

##########
File path: config_center/nacos/client.go
##########
@@ -50,6 +51,15 @@ type NacosClient struct {
 	onceClose  func()
 }
 
+func init() {
+	switch runtime.GOOS {
+	case "windows":
+		logDir = "logs\\nacos\\log"
+	default:
+		logDir = "logs/nacos/log"
+	}
+}
+

Review comment:
       In addition to set default value for `logDir`, we should provide a config item to change this value




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #591: Fix: Nacos client logDir path seperator

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #591:
URL: https://github.com/apache/dubbo-go/pull/591#issuecomment-640994669


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=h1) Report
   > Merging [#591](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/106040d53d8e0f799615fd3f4796fb2c9008d9fc&el=desc) will **increase** coverage by `0.59%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/591/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #591      +/-   ##
   ===========================================
   + Coverage    66.80%   67.39%   +0.59%     
   ===========================================
     Files          185      188       +3     
     Lines         9749     9858     +109     
   ===========================================
   + Hits          6513     6644     +131     
   + Misses        2600     2560      -40     
   - Partials       636      654      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `74.79% <66.66%> (+19.24%)` | :arrow_up: |
   | [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `56.81% <0.00%> (-9.10%)` | :arrow_down: |
   | [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
   | [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `70.83% <0.00%> (-1.64%)` | :arrow_down: |
   | [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
   | [cluster/cluster\_impl/failover\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbG92ZXJfY2x1c3Rlcl9pbnZva2VyLmdv) | `71.15% <0.00%> (-1.19%)` | :arrow_down: |
   | [cluster/cluster\_impl/forking\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZm9ya2luZ19jbHVzdGVyX2ludm9rZXIuZ28=) | `58.33% <0.00%> (-0.21%)` | :arrow_down: |
   | [filter/filter\_impl/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvc2lnbl91dGlsLmdv) | `69.23% <0.00%> (ø)` | |
   | [filter/filter\_impl/auth/consumer\_sign.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvY29uc3VtZXJfc2lnbi5nbw==) | `60.00% <0.00%> (ø)` | |
   | [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <0.00%> (ø)` | |
   | ... and [16 more](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=footer). Last update [106040d...c698284](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org