You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/21 08:33:28 UTC
[GitHub] [kafka] showuon commented on a change in pull request #8646: KAFKA-9974: Fix flaky test by removing unneeded asserts
showuon commented on a change in pull request #8646:
URL: https://github.com/apache/kafka/pull/8646#discussion_r428519103
##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java
##########
@@ -133,11 +133,6 @@ public void shouldApplyUpdatesToStandbyStore() throws Exception {
kafkaStreams1WasFirstActive = false;
}
- // Assert that no restore has occurred, ensures that when we check later that the restore
- // notification actually came from after the rebalance.
- assertThat(listener.startOffset, is(equalTo(0L)));
- assertThat(listener.totalNumRestored, is(equalTo(0L)));
Review comment:
Sorry @mjsax , I tried to trace the code to find out why that would happen, but I still can't figure it out. Do you have any suggestion for it? If not, I think we can have more clear message output when this assert failure happen again. I'm not sure if the info is enough if the error happened again. And not sure if you have any thoughts about it?
It'll look like this when assert failure.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org