Re: [PR] KAFKA-20161 Group configuration for share.renew.acknowledge.enable [kafka]

["AndrewJSchofield (via GitHub)" <gi...@apache.org>]

AndrewJSchofield commented on code in PR #21467:
URL: https://github.com/apache/kafka/pull/21467#discussion_r2874848912


##########
core/src/test/java/kafka/server/share/ShareFetchUtilsTest.java:
##########
@@ -747,6 +748,24 @@ void testDeliveryCountLimitOrDefaultWithoutGroupConfig() {
         assertEquals(5, ShareFetchUtils.deliveryCountLimitOrDefault(groupConfigManager, "test-group", 5));
     }
 
+    @Test
+    void testIsNewAcknowledgeDisabledWithGroupConfig() {

Review Comment:
   This should be `testIsRenewAcknowledgeDisabledWithGroupConfig`. There's no such thing as "NewAcknowledge". :) 



##########
core/src/main/java/kafka/server/share/ShareFetchUtils.java:
##########
@@ -275,6 +276,20 @@ public static int recordLockDurationMsOrDefault(GroupConfigManager groupConfigMa
         return defaultValue;
     }
 
+    /**
+     * The method is used to check if renew acknowledge is enabled for the group. If the group config
+     * is present, then the value from the group config is used. Otherwise, the default value is used.
+     *
+     * @param groupConfigManager The group config manager.
+     * @param groupId The group id for which the renew acknowledge enable is to be checked.
+     * @return true if renew acknowledge is enabled for the group, false otherwise.
+     */
+    public static boolean isRenewAcknowledgeEnabled(GroupConfigManager groupConfigManager, String groupId) {

Review Comment:
   @chia7712 Are you happy with this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org