You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2013/10/24 00:12:44 UTC

[jira] [Commented] (TS-2230) header_rewrite should support the same hook-management that header_filter does for remap rules

    [ https://issues.apache.org/jira/browse/TS-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803403#comment-13803403 ] 

ASF subversion and git services commented on TS-2230:
-----------------------------------------------------

Commit 9dcd00b8f82ec0a2678ae11ae739f68d0a496191 in branch refs/heads/master from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=9dcd00b ]

TS-2230 header_rewrite should support the same hook-management that
        header_filter does for remap rules.

This allows for injecting hook / rules from remap.config into hooks
outside of the remap phase itself. This is particularly useful for
doing header filtering on responses from an origin, based on which
remap rule triggered. With this, a remap.config instance can do e.g.

cond %{READ_RESPONSE_HDR_HOOK}
cond %{STATUS} >199    [AND]
cond %{STATUS} <299
rm-header Cache-Control
add-header Cache-Control "max-age=3600"

(we should add a set-header, but that's a different bug).

TS-2227 This commit also allows for multiple configs per line

This allows a remap.config file to have multiple @pparam's with
configs (such that you can e.g. share one across mulitple rules).
This also works for the global config(s) in plugin.config.

I accidentally merged the two patches, hence just one commit.


> header_rewrite should support the same hook-management that header_filter does for remap rules
> ----------------------------------------------------------------------------------------------
>
>                 Key: TS-2230
>                 URL: https://issues.apache.org/jira/browse/TS-2230
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: Plugins
>            Reporter: Leif Hedstrom
>            Assignee: Leif Hedstrom
>             Fix For: 4.1.0
>
>
> In header_filter, you can use the per-remap rules, yet specify that a rule should apply to a specific hook. We should try to support the same in header_rewrite
> This requires that we also allow header_rewrite to be invoked without a global configuration. This is to allow the support for only remap.config use.



--
This message was sent by Atlassian JIRA
(v6.1#6144)