You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/10 17:03:06 UTC

[GitHub] [incubator-gobblin] sv2000 opened a new pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable

sv2000 opened a new pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable
URL: https://github.com/apache/incubator-gobblin/pull/2916

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1076

### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Currently, the root path for the cluster working directory is derived from user's home directory. This task allows the root directory to be configurable.

### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Existing unit tests.

### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-gobblin] autumnust commented on issue #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable

Posted by GitBox <gi...@apache.org>.

autumnust commented on issue #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable
URL: https://github.com/apache/incubator-gobblin/pull/2916#issuecomment-597314919
 
 
   +1 LGTM. 
   Waiting for travis for finish, and looks like there's conflicts of merging 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable

Posted by GitBox <gi...@apache.org>.

autumnust commented on a change in pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable
URL: https://github.com/apache/incubator-gobblin/pull/2916#discussion_r390549954
 
 

 ##########
 File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java
 ##########
 @@ -113,6 +107,9 @@
  */
 @Alpha
 public class GobblinTaskRunner implements StandardMetricsBridge {
+  // Working directory key for applications. This config is set dynamically.
+  public static final String CLUSTER_APP_WORK_DIR = GobblinClusterConfigurationKeys.GOBBLIN_CLUSTER_PREFIX + "appWorkDir";
 
 Review comment:
   If set dynamically, shall make it package private instead of globally accessible ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable

Posted by GitBox <gi...@apache.org>.

autumnust commented on a change in pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable
URL: https://github.com/apache/incubator-gobblin/pull/2916#discussion_r390550457
 
 

 ##########
 File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java
 ##########
 @@ -437,17 +434,6 @@ public void run() {
     });
   }
 
-  private FileSystem buildFileSystem(Config config, Configuration conf)
 
 Review comment:
   call out on reducing code duplication ! 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] asfgit closed pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable

Posted by GitBox <gi...@apache.org>.

asfgit closed pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable
URL: https://github.com/apache/incubator-gobblin/pull/2916
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable

Posted by GitBox <gi...@apache.org>.

autumnust commented on a change in pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable
URL: https://github.com/apache/incubator-gobblin/pull/2916#discussion_r390553518
 
 

 ##########
 File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterUtils.java
 ##########
 @@ -63,8 +68,9 @@ public static Path getAppWorkDirPath(FileSystem fs, String applicationName, Stri
 
   public static Path getAppWorkDirPathFromConfig(Config config, FileSystem fs,
       String applicationName, String applicationId) {
-    if (config.hasPath(CLUSTER_WORK_DIR)) {
-      return new Path(config.getString(CLUSTER_WORK_DIR));
+    if (config.hasPath(GobblinClusterConfigurationKeys.CLUSTER_WORK_DIR)) {
+      return new Path(new Path(fs.getUri()), PathUtils.combinePaths(config.getString(GobblinClusterConfigurationKeys.CLUSTER_WORK_DIR),
 
 Review comment:
   Shall we log the app-specific work directory here, since users may not expect applicationName / ID appearing ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] sv2000 commented on issue #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable

Posted by GitBox <gi...@apache.org>.

sv2000 commented on issue #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable
URL: https://github.com/apache/incubator-gobblin/pull/2916#issuecomment-597325370
 
 
   Fixed the merge conflicts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable

Posted by GitBox <gi...@apache.org>.

sv2000 commented on a change in pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable
URL: https://github.com/apache/incubator-gobblin/pull/2916#discussion_r390609238
 
 

 ##########
 File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java
 ##########
 @@ -113,6 +107,9 @@
  */
 @Alpha
 public class GobblinTaskRunner implements StandardMetricsBridge {
+  // Working directory key for applications. This config is set dynamically.
+  public static final String CLUSTER_APP_WORK_DIR = GobblinClusterConfigurationKeys.GOBBLIN_CLUSTER_PREFIX + "appWorkDir";
 
 Review comment:
   Making it package-private makes the config inaccessible inside IntegrationBasicSuite. Hence, set it to public.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable

Posted by GitBox <gi...@apache.org>.

sv2000 commented on a change in pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable
URL: https://github.com/apache/incubator-gobblin/pull/2916#discussion_r390608708
 
 

 ##########
 File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterUtils.java
 ##########
 @@ -63,8 +68,9 @@ public static Path getAppWorkDirPath(FileSystem fs, String applicationName, Stri
 
   public static Path getAppWorkDirPathFromConfig(Config config, FileSystem fs,
       String applicationName, String applicationId) {
-    if (config.hasPath(CLUSTER_WORK_DIR)) {
-      return new Path(config.getString(CLUSTER_WORK_DIR));
+    if (config.hasPath(GobblinClusterConfigurationKeys.CLUSTER_WORK_DIR)) {
+      return new Path(new Path(fs.getUri()), PathUtils.combinePaths(config.getString(GobblinClusterConfigurationKeys.CLUSTER_WORK_DIR),
 
 Review comment:
   Added logs on the caller side instead of inside the utility method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services