You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zzcclp (via GitHub)" <gi...@apache.org> on 2025/05/20 07:57:09 UTC
[PR] [GLUTEN-9697][CH] Add 'reorg' command ut for the mergetree + delta dv [incubator-gluten]
zzcclp opened a new pull request, #9699:
URL: https://github.com/apache/incubator-gluten/pull/9699
## What changes were proposed in this pull request?
[CH] Add 'reorg' command ut for the mergetree + delta dv
Close #9697.
(Fixes: #9697)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9697][CH] Add 'reorg' command ut for the mergetree + delta dv [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9699:
URL: https://github.com/apache/incubator-gluten/pull/9699#issuecomment-2893340590
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9697][CH] Add 'reorg' command ut for the mergetree + delta dv [incubator-gluten]
Posted by "loneylee (via GitHub)" <gi...@apache.org>.
loneylee commented on PR #9699:
URL: https://github.com/apache/incubator-gluten/pull/9699#issuecomment-2896178272
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9697][CH] Add 'reorg' command ut for the mergetree + delta dv [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9699:
URL: https://github.com/apache/incubator-gluten/pull/9699#issuecomment-2894332333
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9697][CH] Add 'reorg' command ut for the mergetree + delta dv [incubator-gluten]
Posted by "zzcclp (via GitHub)" <gi...@apache.org>.
zzcclp merged PR #9699:
URL: https://github.com/apache/incubator-gluten/pull/9699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9697][CH] Add 'reorg' command ut for the mergetree + delta dv [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9699:
URL: https://github.com/apache/incubator-gluten/pull/9699#issuecomment-2893339712
https://github.com/apache/incubator-gluten/issues/9697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9697][CH] Add 'reorg' command ut for the mergetree + delta dv [incubator-gluten]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #9699:
URL: https://github.com/apache/incubator-gluten/pull/9699#discussion_r2097256721
##########
backends-clickhouse/src-delta-32/test/scala/org/apache/spark/gluten/delta/GlutenDeltaMergeTreeDeletionVectorSuite.scala:
##########
@@ -160,5 +165,106 @@ class GlutenDeltaMergeTreeDeletionVectorSuite extends CreateMergeTreeSuite {
)
checkFallbackOperators(df, 0)
}
+
+ test("Gluten-9697: Add 'reorg' command ut for the mergetree + delta dv") {
+ val tableName = "mergetree_delta_dv_reorg"
+ withTable(tableName) {
+ withTempDir {
+ dirName =>
+ val s = createTableBuilder(tableName, "clickhouse", s"$dirName/$tableName")
+ .withProps(Map("delta.enableDeletionVectors" -> "'true'"))
Review Comment:
The Map value for delta.enableDeletionVectors includes nested quotes, passing "'true'" instead of "true"; remove the extra quotes so the property is correctly enabled.
```suggestion
.withProps(Map("delta.enableDeletionVectors" -> "true"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org