You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Stephen Connolly (JIRA)" <ji...@apache.org> on 2018/06/17 21:43:02 UTC
[jira] [Updated] (MNG-6164) Collections inconsistently immutable
[ https://issues.apache.org/jira/browse/MNG-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Connolly updated MNG-6164:
----------------------------------
Fix Version/s: (was: 3.6.0-candidate)
3.6.x-candidate
> Collections inconsistently immutable
> ------------------------------------
>
> Key: MNG-6164
> URL: https://issues.apache.org/jira/browse/MNG-6164
> Project: Maven
> Issue Type: Improvement
> Affects Versions: 3.5.0
> Reporter: Christian Schulte
> Assignee: Karl Heinz Marbaise
> Priority: Minor
> Fix For: 3.6.x-candidate
>
>
> There are plenty of places where empty collections are returned from public API in methods written like:
> {code}
> public List<Exception> getExceptions()
> {
> return exceptions == null ? Collections.<Exception>emptyList() : exceptions;
> }
> {code}
> The issue with this is that the empty list is immutable but the collection returned for the nun-null case is not immutable.
> All those methods should return a collection with consistent "mutability": either mutable, either immutable.
> Given empty immutable collections do not cause harm until now, switching consistently to immutable collections is more conservative and should not be risky
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)