[commons-crypto] branch master updated: Need to disable another test

[se...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-crypto.git


The following commit(s) were added to refs/heads/master by this push:
     new 31c5af1  Need to disable another test
31c5af1 is described below

commit 31c5af14013d0f63ed995bd5cec0725343cb77b8
Author: Sebb <se...@apache.org>
AuthorDate: Sat Jul 2 00:47:30 2022 +0100

    Need to disable another test
---
 .../java/org/apache/commons/crypto/NativeCodeLoaderTest.java     | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/test/java/org/apache/commons/crypto/NativeCodeLoaderTest.java b/src/test/java/org/apache/commons/crypto/NativeCodeLoaderTest.java
index ee4d84a..8b69c83 100644
--- a/src/test/java/org/apache/commons/crypto/NativeCodeLoaderTest.java
+++ b/src/test/java/org/apache/commons/crypto/NativeCodeLoaderTest.java
@@ -49,6 +49,12 @@ public class NativeCodeLoaderTest {
     }
 
     @Test
+    @Disabled("Causes crash on Ubuntu when compiled with Java 17")
+    // The following error is reported:
+    // "Corrupted channel by directly writing to native stream in forked JVM 1"
+    // Note that this appears during a subsequent test, and does not
+    // happen every time.
+    // At this point it is not known where the native stream is written.
     public void testCanLoadIfPresent() {
         assumeTrue(NativeCodeLoader.isNativeCodeLoaded());
         // This will try to reload the library, so should work
@@ -57,6 +63,9 @@ public class NativeCodeLoaderTest {
 
     @Test
     @Disabled("Seems to cause issues with other tests on Linux; disable for now")
+    // It causes problems because the system properties are temporarily changed.
+    // However properties are only fetched once, thus the test either corrupts the settings
+    // or does not work, depending on the order of tests.
     public void testUnSuccessfulLoad() throws Exception {
         final String nameKey = System.getProperty(Crypto.LIB_NAME_KEY);
         final String pathKey = System.getProperty(Crypto.LIB_PATH_KEY);