You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2006/03/24 03:05:51 UTC

svn commit: r388321 - /jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java

Author: sebb
Date: Thu Mar 23 18:05:50 2006
New Revision: 388321

URL: http://svn.apache.org/viewcvs?rev=388321&view=rev
Log:
Don't write binary responseData to the file

Modified:
    jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java

Modified: jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java
URL: http://svn.apache.org/viewcvs/jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java?rev=388321&r1=388320&r2=388321&view=diff
==============================================================================
--- jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java (original)
+++ jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java Thu Mar 23 18:05:50 2006
@@ -132,8 +132,14 @@
 		if (save.saveResponseData(res)) {
 			writer.startNode(TAG_RESPONSE_DATA);
 			try {
-				writer.addAttribute(ATT_CLASS, JAVA_LANG_STRING);
-				writer.setValue(new String(res.getResponseData(), res.getDataEncoding()));
+                String ct = res.getContentType();
+                if (ct.startsWith("text/")){// $NON-NLS-1$
+    				writer.addAttribute(ATT_CLASS, JAVA_LANG_STRING);
+    				writer.setValue(new String(res.getResponseData(), res.getDataEncoding()));
+                } else {
+                    writer.addAttribute(ATT_CLASS, JAVA_LANG_STRING);
+                    writer.setValue(res.getURL().toExternalForm());//TODO - better representation                  
+                }
 			} catch (UnsupportedEncodingException e) {
 				writer.setValue("Unsupported encoding in response data, can't record.");
 			}



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org