You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/04 16:41:59 UTC

[GitHub] [beam] tvalentyn commented on a change in pull request #12150: [BEAM-10398] Use GitHub Actions in wheels release process for Python

tvalentyn commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r465185332



##########
File path: release/src/main/scripts/download_github_actions_artifacts.py
##########
@@ -170,7 +170,7 @@ def get_last_run_id(
       f"GCS location corresponding to artifacts built in this run: "
       f"gs://beam-wheels-staging/{release_branch}/{release_commit}-{last_run_id}/"
   )
-  return safe_get(last_run, "id")
+  return last_run_id

Review comment:
       will probably be ok. if it's extra complexity to skip that step I wouldn't about it worry about it for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org