You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/15 17:15:03 UTC
[GitHub] [arrow] bkietz opened a new pull request #7776: ARROW-9486: [C++][Dataset] Support implicit cast of InExpression::set to dict
bkietz opened a new pull request #7776:
URL: https://github.com/apache/arrow/pull/7776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on a change in pull request #7776: ARROW-9486: [C++][Dataset] Support implicit cast of InExpression::set to dict
Posted by GitBox <gi...@apache.org>.
bkietz commented on a change in pull request #7776:
URL: https://github.com/apache/arrow/pull/7776#discussion_r455267777
##########
File path: cpp/src/arrow/dataset/filter.cc
##########
@@ -931,6 +931,22 @@ Result<std::shared_ptr<DataType>> FieldExpression::Validate(const Schema& schema
return null();
}
+Result<Datum> CastOrDictionaryEncode(const Datum& arr,
Review comment:
https://issues.apache.org/jira/browse/ARROW-9492
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #7776: ARROW-9486: [C++][Dataset] Support implicit cast of InExpression::set to dict
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7776:
URL: https://github.com/apache/arrow/pull/7776#discussion_r455250939
##########
File path: cpp/src/arrow/dataset/filter.cc
##########
@@ -931,6 +931,22 @@ Result<std::shared_ptr<DataType>> FieldExpression::Validate(const Schema& schema
return null();
}
+Result<Datum> CastOrDictionaryEncode(const Datum& arr,
Review comment:
This doesn't seem to be static nor in the anonymous namespace?
(ditto for other private functions in this file?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7776: ARROW-9486: [C++][Dataset] Support implicit cast of InExpression::set to dict
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7776:
URL: https://github.com/apache/arrow/pull/7776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7776: ARROW-9486: [C++][Dataset] Support implicit cast of InExpression::set to dict
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7776:
URL: https://github.com/apache/arrow/pull/7776#issuecomment-658896704
https://issues.apache.org/jira/browse/ARROW-9486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org