You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucy.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/11/02 18:22:27 UTC
[lucy-issues] [jira] [Commented] (LUCY-282) Refine and test Go bindings

    [ https://issues.apache.org/jira/browse/LUCY-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985570#comment-14985570 ] 

ASF GitHub Bot commented on LUCY-282:
-------------------------------------

GitHub user rectang opened a pull request:

    https://github.com/apache/lucy/pull/26

    LUCY-282 Test Go bindings for Index compoments pt1

    Tune and and test the Go bindings for various "Index" components.
    
    The autogenerated Go bindings suffice for some of these classes, but many others require tweaking. The most common customizations relate to providing idiomatic error handling and subtyping slices.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rectang/lucy LUCY-282-test-index-go-pt1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucy/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
    
----
commit 71dd0aa830e6dca814c0e5489074eea28307e3ee
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-10-29T18:05:01Z

    Tune and test Go bindings for Indexer.

commit 70d9076ccafc9bb9af16d3fe14d780ae5abc2d1b
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-10-29T20:06:07Z

    Tune and test Go bindings for BackgroundMerger.

commit 53131d1a7ca555ca666d11885c0445da9d248d55
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-10-30T02:12:58Z

    Tune and test Go bindings for IndexManager.

commit 07fa7b0b9aa5d3f0087c2fdc09752b284c8885b0
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-10-30T17:02:11Z

    Test TermInfo Go bindings.

commit 19e0715daf30769ee15045bef0a549390af16b65
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-10-30T19:32:28Z

    Test Go bindings for BitVecDelDocs.

commit 115b04c9d652bf691fe873d62515fcba5c2a116a
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-10-31T00:41:31Z

    Tune and test Go bindings for TermVector.

commit 8eefef8eeed524308fdef47c34642b954908d8ea
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-10-31T22:10:45Z

    Small changes to Snapshot for Go.
    
    Treat empty String the same as NULL.
    
    Don't document "an assignment idiom" when returning the object, because
    the Go method binding returns a tuple of (Snapshot, error) and thus
    doesn't allow an assignment idiom.

commit a8bb3b5e03d3a28996705488ecbdbf54b4206f4e
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-10-31T22:12:23Z

    Tune and test Go bindings for Snapshot.

commit 54733ad5b75cf7bb1ca75081f4a97ec12b1bd7f6
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-11-01T00:31:37Z

    Test Go bindings for DocVector.

commit 5cbd112fff62c7b3f165003a898eb4ac252297f2
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-11-01T01:25:30Z

    Test Go bindings for SortCache.

commit c8df9f639b10cf4687669daaf8e1628268b89698
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-11-01T04:01:24Z

    Tune and test Go bindings for Segment.

commit 656f6932893ef72672a09292dd94ae04339f6ba7
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-11-01T04:01:51Z

    Test Go bindings for Similarity.

commit fb69e384524d563aa0636070fcc2159970003acd
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-11-01T17:58:37Z

    Test Go bindings for FilePurger.

commit c03af4b20b1a4ce3c7f3b57044253ea599c3e236
Author: Marvin Humphrey <ma...@rectangular.com>
Date:   2015-11-02T02:25:04Z

    Test Go bindings for Inverter.

----


> Refine and test Go bindings
> ---------------------------
>
>                 Key: LUCY-282
>                 URL: https://issues.apache.org/jira/browse/LUCY-282
>             Project: Lucy
>          Issue Type: Improvement
>          Components: Go bindings
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
>             Fix For: 0.5.0
>
>
> Now that we have roughly useful automated Go bindings, work through them fine tuning for Go idiomatic usage and writing tests to ensure the Go bindings work as expected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)