You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2004/06/09 18:10:48 UTC

DO NOT REPLY [Bug 29470] New: - GlobalResourcesLifecycleListener: Error message should be debug message

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=29470>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29470

GlobalResourcesLifecycleListener: Error message should be debug message

           Summary: GlobalResourcesLifecycleListener: Error message should
                    be debug message
           Product: Tomcat 5
           Version: 5.0.25
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Catalina
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: rainer.jung@kippdata.de
                CC: rainer.jung@kippdata.de


In

org/apache/catalina/mbeans/GlobalResourcesLifecycleListener.java rev=1.4 

in line 205 there is a wrong log level log.error(). This should be log.debug()
instead. The message only shows up, when debug is set to >=3, but the message
text says ERROR, although it is just an informational message. All similar
messages in GlobalResourcesLifecycleListener are with level debug. Example message:

2004-06-09 17:58:33,133 (main)
org.apache.catalina.mbeans.GlobalResourcesLifecycleListener/ERROR:   Creating
Role MBean for role <role rolename="manager"/>

Context diff for suggested patch follows, thanks for considering.

***************
*** 202,208 ****
          while (roles.hasNext()) {
              Role role = (Role) roles.next();
              if (debug >= 3) {
!                 log.error("  Creating Role MBean for role " + role);
              }
              if (MBeanUtils.createMBean(role) == null) {
                  throw new IllegalArgumentException
--- 202,208 ----
          while (roles.hasNext()) {
              Role role = (Role) roles.next();
              if (debug >= 3) {
!                 log.debug("Creating Role MBean for role " + role);
              }
              if (MBeanUtils.createMBean(role) == null) {
                  throw new IllegalArgumentException

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org