You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/28 10:45:21 UTC
[jira] [Commented] (FLINK-4703) RpcCompletenessTest: Add support
for type arguments and subclasses
[ https://issues.apache.org/jira/browse/FLINK-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529239#comment-15529239 ]
ASF GitHub Bot commented on FLINK-4703:
---------------------------------------
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2561
[FLINK-4703] RpcCompletenessTest: Add support for type arguments and subclasses
This is a prerequisite for merging #2540 which relies on the class hierarchy features.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-4703
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2561
----
commit 442ee17bec78c96697101f5089465916f471478a
Author: Maximilian Michels <mx...@apache.org>
Date: 2016-09-28T10:39:30Z
[FLINK-4703] RpcCompletenessTest: Add support for type arguments and subclasses
----
> RpcCompletenessTest: Add support for type arguments and subclasses
> ------------------------------------------------------------------
>
> Key: FLINK-4703
> URL: https://issues.apache.org/jira/browse/FLINK-4703
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 1.2.0
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Minor
> Fix For: 1.2.0
>
>
> The RpcCompletenessTest doesn't work for class hierarchies because it assumes that the Gateway argument always is provided in the super class.
> Further, the RpcCompletenessTest should skip abstract classes and classes which have type parameters bound to {{RpcGateway.class}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)