You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by pi...@apache.org on 2026/10/16 19:59:07 UTC
(iggy) branch master updated: chore(csharp): remove FluentAssertions from tests (#4578)
This is an automated email from the ASF dual-hosted git repository.
spetz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iggy.git
The following commit(s) were added to refs/heads/master by this push:
new d1fe677db chore(csharp): remove FluentAssertions from tests (#4578)
d1fe677db is described below
commit d1fe677db5c286f18a3823e25c37339d15e33ba8
Author: Łukasz Zborek <lu...@gmail.com>
AuthorDate: Fri Oct 16 21:59:01 2026 +0200
chore(csharp): remove FluentAssertions from tests (#4578)
The C# unit tests referenced FluentAssertions 8, which is released under
the Xceed Community License rather than an open source license. Only
IggyTypedPublisherTests used it, while the other unit tests already
rely on xUnit Assert.
The assertions in IggyTypedPublisherTests now use xUnit Assert, and the
FluentAssertions package is removed from Directory.Packages.props and
the test project. BeEquivalentTo maps to Assert.Equivalent in strict
mode, so order still does not matter but extra items fail.
---
foreign/csharp/Directory.Packages.props | 1 -
.../csharp/Iggy_SDK_Tests/Iggy_SDK_Tests.csproj | 1 -
.../PublisherTests/IggyTypedPublisherTests.cs | 68 +++++++++++-----------
3 files changed, 35 insertions(+), 35 deletions(-)
diff --git a/foreign/csharp/Directory.Packages.props b/foreign/csharp/Directory.Packages.props
index 9db70c921..a50363111 100644
--- a/foreign/csharp/Directory.Packages.props
+++ b/foreign/csharp/Directory.Packages.props
@@ -23,7 +23,6 @@ under the License.
<CentralPackageTransitivePinningEnabled>false</CentralPackageTransitivePinningEnabled>
</PropertyGroup>
<ItemGroup>
- <PackageVersion Include="FluentAssertions" Version="8.11.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="10.0.12" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.10.1" />
diff --git a/foreign/csharp/Iggy_SDK_Tests/Iggy_SDK_Tests.csproj b/foreign/csharp/Iggy_SDK_Tests/Iggy_SDK_Tests.csproj
index 7f6b1a61b..f088fc0c6 100644
--- a/foreign/csharp/Iggy_SDK_Tests/Iggy_SDK_Tests.csproj
+++ b/foreign/csharp/Iggy_SDK_Tests/Iggy_SDK_Tests.csproj
@@ -31,7 +31,6 @@ under the License.
</PropertyGroup>
<ItemGroup>
- <PackageReference Include="FluentAssertions" />
<PackageReference Include="Microsoft.NET.Test.Sdk" />
<PackageReference Include="Microsoft.Testing.Extensions.CodeCoverage" />
<PackageReference Include="Moq" />
diff --git a/foreign/csharp/Iggy_SDK_Tests/PublisherTests/IggyTypedPublisherTests.cs b/foreign/csharp/Iggy_SDK_Tests/PublisherTests/IggyTypedPublisherTests.cs
index 26c81922d..d29c98dec 100644
--- a/foreign/csharp/Iggy_SDK_Tests/PublisherTests/IggyTypedPublisherTests.cs
+++ b/foreign/csharp/Iggy_SDK_Tests/PublisherTests/IggyTypedPublisherTests.cs
@@ -24,7 +24,6 @@ using Apache.Iggy.Headers;
using Apache.Iggy.IggyClient;
using Apache.Iggy.Messages;
using Apache.Iggy.Publishers;
-using FluentAssertions;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
using Partitioning = Apache.Iggy.Kinds.Partitioning;
@@ -47,10 +46,10 @@ public class IggyTypedPublisherTests
await publisher.SendAsync("hello", id, ct: Ct);
- var sent = recorder.AllMessages.Should().ContainSingle().Subject;
- sent.Id.Should().Be(id.ToUInt128());
- Decode(sent).Should().Be("hello");
- sent.UserHeaders.Should().BeNull();
+ var sent = Assert.Single(recorder.AllMessages);
+ Assert.Equal(id.ToUInt128(), sent.Id);
+ Assert.Equal("hello", Decode(sent));
+ Assert.Null(sent.UserHeaders);
}
[Fact]
@@ -61,9 +60,9 @@ public class IggyTypedPublisherTests
await publisher.SendAsync("hello", ct: Ct);
- var sent = recorder.AllMessages.Should().ContainSingle().Subject;
- sent.Id.Should().Be(UInt128.Zero);
- Decode(sent).Should().Be("hello");
+ var sent = Assert.Single(recorder.AllMessages);
+ Assert.Equal(UInt128.Zero, sent.Id);
+ Assert.Equal("hello", Decode(sent));
}
[Fact]
@@ -78,8 +77,9 @@ public class IggyTypedPublisherTests
await publisher.SendAsync("hello", userHeaders: headers, ct: Ct);
- var sent = recorder.AllMessages.Should().ContainSingle().Subject;
- sent.UserHeaders.Should().ContainKey(HeaderKey.FromString("k"));
+ var sent = Assert.Single(recorder.AllMessages);
+ Assert.NotNull(sent.UserHeaders);
+ Assert.Contains(HeaderKey.FromString("k"), sent.UserHeaders);
}
[Fact]
@@ -90,7 +90,7 @@ public class IggyTypedPublisherTests
await publisher.SendAsync(new[] { "a", "b", "c" }, Ct);
- recorder.AllMessages.Select(Decode).Should().Equal("a", "b", "c");
+ Assert.Equal(["a", "b", "c"], recorder.AllMessages.Select(Decode));
}
[Fact]
@@ -101,7 +101,7 @@ public class IggyTypedPublisherTests
await publisher.SendAsync(Array.Empty<string>(), Ct);
- recorder.Calls.Should().BeEmpty();
+ Assert.Empty(recorder.Calls);
}
[Fact]
@@ -118,16 +118,17 @@ public class IggyTypedPublisherTests
await publisher.SendAsync(
new (string, Guid?, Dictionary<HeaderKey, HeaderValue>?)[] { ("a", id, headers), ("b", null, null) }, Ct);
- recorder.AllMessages.Should().HaveCount(2);
+ Assert.Equal(2, recorder.AllMessages.Count);
var first = recorder.AllMessages[0];
- first.Id.Should().Be(id.ToUInt128());
- Decode(first).Should().Be("a");
- first.UserHeaders.Should().ContainKey(HeaderKey.FromString("k"));
+ Assert.Equal(id.ToUInt128(), first.Id);
+ Assert.Equal("a", Decode(first));
+ Assert.NotNull(first.UserHeaders);
+ Assert.Contains(HeaderKey.FromString("k"), first.UserHeaders);
var second = recorder.AllMessages[1];
- Decode(second).Should().Be("b");
- second.Id.Should().Be(UInt128.Zero);
- second.UserHeaders.Should().BeNull();
+ Assert.Equal("b", Decode(second));
+ Assert.Equal(UInt128.Zero, second.Id);
+ Assert.Null(second.UserHeaders);
}
[Fact]
@@ -140,10 +141,10 @@ public class IggyTypedPublisherTests
await publisher.SendAsync("hello", ct: Ct);
- var (stream, topic, partitioning, _) = recorder.Calls.Should().ContainSingle().Subject;
- stream.Should().Be(Stream);
- topic.Should().Be(Topic);
- partitioning.Kind.Should().Be(Enums.Partitioning.PartitionId);
+ var (stream, topic, partitioning, _) = Assert.Single(recorder.Calls);
+ Assert.Equal(Stream, stream);
+ Assert.Equal(Topic, topic);
+ Assert.Equal(Enums.Partitioning.PartitionId, partitioning.Kind);
}
[Fact]
@@ -187,9 +188,9 @@ public class IggyTypedPublisherTests
await publisher.SendAsync("hello", id, ct: Ct);
await publisher.WaitUntilAllSendsAsync(Ct);
- var sent = recorder.AllMessages.Should().ContainSingle().Subject;
- sent.Id.Should().Be(id.ToUInt128());
- Decode(sent).Should().Be("hello");
+ var sent = Assert.Single(recorder.AllMessages);
+ Assert.Equal(id.ToUInt128(), sent.Id);
+ Assert.Equal("hello", Decode(sent));
}
[Fact]
@@ -201,7 +202,7 @@ public class IggyTypedPublisherTests
await publisher.SendAsync(new[] { "a", "b", "c" }, Ct);
await publisher.WaitUntilAllSendsAsync(Ct);
- recorder.AllMessages.Select(Decode).Should().BeEquivalentTo("a", "b", "c");
+ Assert.Equivalent(new[] { "a", "b", "c" }, recorder.AllMessages.Select(Decode), true);
}
[Fact]
@@ -219,10 +220,11 @@ public class IggyTypedPublisherTests
Ct);
await publisher.WaitUntilAllSendsAsync(Ct);
- var sent = recorder.AllMessages.Should().ContainSingle().Subject;
- sent.Id.Should().Be(id.ToUInt128());
- Decode(sent).Should().Be("a");
- sent.UserHeaders.Should().ContainKey(HeaderKey.FromString("k"));
+ var sent = Assert.Single(recorder.AllMessages);
+ Assert.Equal(id.ToUInt128(), sent.Id);
+ Assert.Equal("a", Decode(sent));
+ Assert.NotNull(sent.UserHeaders);
+ Assert.Contains(HeaderKey.FromString("k"), sent.UserHeaders);
}
[Fact]
@@ -234,7 +236,7 @@ public class IggyTypedPublisherTests
await publisher.SendAsync(Array.Empty<string>(), Ct);
await publisher.WaitUntilAllSendsAsync(Ct);
- recorder.Calls.Should().BeEmpty();
+ Assert.Empty(recorder.Calls);
}
[Fact]
@@ -260,7 +262,7 @@ public class IggyTypedPublisherTests
IEnumerable<string> expected = Enumerable.Range(0, producers)
.SelectMany(producer => Enumerable.Range(0, perProducer).Select(i => $"p{producer}-{i}"));
- recorder.AllMessages.Select(Decode).Should().BeEquivalentTo(expected);
+ Assert.Equivalent(expected, recorder.AllMessages.Select(Decode), true);
}
[Theory]