You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/07/24 06:16:10 UTC
[GitHub] [incubator-dolphinscheduler] JinyLeeChina opened a new pull request #3300: [BugFix] isssue #3299
JinyLeeChina opened a new pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300
Fixed alert cannot be notified，when master or worker shutdown。
I think the reason for this is that Jackson can't parse JSON fields with single quotes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-663387747
Hi,
The type of `{'a': "b"}` and `{'a': 'b'}` is not a standard json string, but if we add the `ALLOW_SINGLE_QUOTES`, it will be formatted correctly by `JSONUtils`. If we just add `ALLOW_SINGLE_QUOTES` for `JSONUtils`, perhaps it will cause some unforeseen bugs.
I think a better way to fix this bug is format the original json not to change the JSONUtils.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] JinyLeeChina closed pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
JinyLeeChina closed pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] break60 commented on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
break60 commented on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-668456000
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] JinyLeeChina commented on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-663386101
Yes, I‘ve fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] JinyLeeChina commented on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-668340296
Update actions.js fixed #3351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] lenboo closed pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
lenboo closed pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-663387747
Hi,
The type of `{'a': "b"}` and `{'a': 'b'}` is not a standard json string, but if we add the `ALLOW_SINGLE_QUOTES`, it will be formatted by `JSONUtils`.
I think a better way to fix this bug is format the original json not the JSONUtils.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-663387747
Hi,
The type of `{'a': "b"}` and `{'a': 'b'}` is not a standard json string, but if we add the `ALLOW_SINGLE_QUOTES`, it will be formatted by `JSONUtils`.
I think a better way to fix this bug is format the original json not to change the JSONUtils.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] JinyLeeChina removed a comment on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
JinyLeeChina removed a comment on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-663386101
Yes, I‘ve fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] lenboo commented on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
lenboo commented on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-668453783
Hi,
Please change the title to [Fix-3299][ui] process_definition_json contains definitionList，but this definitionList is not use . Thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-663387747
Hi,
The type of `{'a': "b"}` and `{'a': 'b'}` is not a standard json string, but if we add the `ALLOW_SINGLE_QUOTES`, it will be formatted correctly by `JSONUtils`. Perhaps the `ALLOW_SINGLE_QUOTES` will cause some unforeseen bugs.
I think a better way to fix this bug is format the original json not the JSONUtils.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] lenboo commented on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
lenboo commented on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-669121107
there is another pr refer to the issue, so i will close this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] JinyLeeChina commented on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-663365483
> Fixed alert cannot be notified，when master or worker shutdown。
> I think the reason for this is that Jackson can't parse JSON fields with single quotes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-663387747
Hi,
The type of `{'a': "b"}` and `{'a': 'b'}` is not a standard json string, but if we add the `ALLOW_SINGLE_QUOTES`, it will be formatted by `JSONUtils`. Perhaps the `ALLOW_SINGLE_QUOTES` will cause some unforeseen bugs.
I think a better way to fix this bug is format the original json not the JSONUtils.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] JinyLeeChina commented on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-664733606
I think we should be compatible with JSON with single quotation marks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-663387747
Hi,
The type of `{'a': "b"}` and `{'a': 'b'}` is not a standard json string, but if we add the `ALLOW_SINGLE_QUOTES`, it will be formatted correctly by `JSONUtils`. If we just add `ALLOW_SINGLE_QUOTES` for `JSONUtils`, perhaps it will cause some unforeseen bugs.
I think a better way to fix this bug is format the original json not the JSONUtils.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on pull request #3300: [BugFix] isssue #3299
Posted by GitBox <gi...@apache.org>.
qiaozhanwei commented on pull request #3300:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-663373312
why all red compile not pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org