You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Olivier Lamy <ol...@apache.org> on 2008/07/26 21:51:24 UTC
Re: svn commit: r680030 - in /maven/plugins/trunk/maven-changes-plugin: ./ src/it/announcement-generate-custom-template/ src/it/announcement-generate-custom-template/src/ src/it/announcement-generate-custom-template/src/changes/ src/it/announcement-g
You're rigth.
I need to find a way to pass it to ProjectResourceLoader.
--
Olivier
2008/7/26 Benjamin Bentmann <be...@udo.edu>:
> Hi Oliver,
>
>> Author: olamy
>> Date: Sat Jul 26 12:13:48 2008
>> New Revision: 680030
>>
>> URL: http://svn.apache.org/viewvc?rev=680030&view=rev
>> Log:
>> [MCHANGES-118] AnnouncementMojo can only load velocity templates from
>> src/main/resources
>>
>> + + // MCHANGES-118 adding the user.dir path
>> + + paths.add( System.getProperty( "user.dir" ) );
>
> Are you sure this is what you want? "user.dir" can be quite anything [0],
> just assume somebody running a reactor build where the working directory is
> usually (but necessarily) the base directory of the execution root. Isn't it
> more the base directory of the current project one would want to use to
> resolve relative paths against?
>
>
> Benjamin
>
>
> [0] http://www.nabble.com/Common-Bugs-p14783703.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r680030 - in /maven/plugins/trunk/maven-changes-plugin: ./ src/it/announcement-generate-custom-template/ src/it/announcement-generate-custom-template/src/ src/it/announcement-generate-custom-template/src/changes/ src/it/announcement-g
Posted by Olivier Lamy <ol...@apache.org>.
Should be ok now.
Thanks,
--
Olivier
2008/7/26 Olivier Lamy <ol...@apache.org>:
> You're rigth.
> I need to find a way to pass it to ProjectResourceLoader.
>
> --
> Olivier
>
>
> 2008/7/26 Benjamin Bentmann <be...@udo.edu>:
>> Hi Oliver,
>>
>>> Author: olamy
>>> Date: Sat Jul 26 12:13:48 2008
>>> New Revision: 680030
>>>
>>> URL: http://svn.apache.org/viewvc?rev=680030&view=rev
>>> Log:
>>> [MCHANGES-118] AnnouncementMojo can only load velocity templates from
>>> src/main/resources
>>>
>>> + + // MCHANGES-118 adding the user.dir path
>>> + + paths.add( System.getProperty( "user.dir" ) );
>>
>> Are you sure this is what you want? "user.dir" can be quite anything [0],
>> just assume somebody running a reactor build where the working directory is
>> usually (but necessarily) the base directory of the execution root. Isn't it
>> more the base directory of the current project one would want to use to
>> resolve relative paths against?
>>
>>
>> Benjamin
>>
>>
>> [0] http://www.nabble.com/Common-Bugs-p14783703.html
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org