You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/02 06:17:28 UTC
[GitHub] TaoLv commented on a change in pull request #12953: Update MKL-DNN
dependency
TaoLv commented on a change in pull request #12953: Update MKL-DNN dependency
URL: https://github.com/apache/incubator-mxnet/pull/12953#discussion_r230278298
##########
File path: tests/cpp/operator/mkldnn_test.cc
##########
@@ -100,9 +100,9 @@ static void VerifyDefMem(const mkldnn::memory &mem) {
TEST(MKLDNN_UTIL_FUNC, MemFormat) {
// Check whether the number of format is correct.
- CHECK_EQ(mkldnn_format_last, 67);
- CHECK_EQ(mkldnn_nchw, 5);
- CHECK_EQ(mkldnn_oihw, 15);
+ CHECK_EQ(mkldnn_format_last, 110);
+ CHECK_EQ(mkldnn_nchw, 7);
Review comment:
Hi @KellenSunderland , data formats are in an enumerate type of MKL-DNN and may be changed in the evolution of MKL-DNN. This test cast is trying to remind the developer who submit PR to update MKL-DNN version in MXNet to take care of the format change of MKL-DNN.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services