You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/20 18:09:54 UTC

[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on a change in pull request #168: resolve empty comment issue for customer and group tasks

PatelVatsalB21 commented on a change in pull request #168:
URL: https://github.com/apache/fineract-cn-mobile/pull/168#discussion_r598142031



##########
File path: app/src/main/java/org/apache/fineract/ui/online/groups/grouptasks/GroupTasksBottomSheetFragment.kt
##########
@@ -120,6 +120,11 @@ class GroupTasksBottomSheetFragment(val group: Group) : FineractBaseBottomSheetD
 
     @OnClick(R.id.btn_submit_task)
     fun submitTask() {
+        if (rootView.et_comment.text.toString().isEmpty()) {

Review comment:
       Looks Good to me. With kotlin you can directly access UI elements
   ```suggestion
           if (et_comment.text.toString().isEmpty()) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org