You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <de...@bloodhound.apache.org> on 2014/09/25 22:00:54 UTC
[Apache Bloodhound] #813: TICKET_VIEW is not sufficient to see
relations
#813: TICKET_VIEW is not sufficient to see relations
-----------------------+----------------------
Reporter: wimh | Owner: nobody
Type: defect | Status: new
Priority: major | Milestone:
Component: relations | Version: 0.8.0dev
Keywords: |
-----------------------+----------------------
An anonymous with all _VIEW permission set, is not able to see the ticket
relations. after adding for example TICKET_APPEND, the relations will be
visible for the anonymous user.
To reproduce, create two tickets in a default installation, add an
"depends on" relation, logout. You are not able to see the relations any
more when viewing either ticket.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/813>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #813: TICKET_VIEW is not sufficient to see
relations
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#813: TICKET_VIEW is not sufficient to see relations
------------------------+-----------------------
Reporter: wimh | Owner: gjm
Type: defect | Status: accepted
Priority: major | Milestone: Release 9
Component: relations | Version: 0.8.0dev
Resolution: | Keywords:
------------------------+-----------------------
Comment (by gjm):
I have created what I think is a more complete solution with [1689326] -
as the repository links are still failing, I have also attached the
equivalent patch here: attachment:813.patch
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/813#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #813: TICKET_VIEW is not sufficient to see
relations
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#813: TICKET_VIEW is not sufficient to see relations
------------------------+-----------------------
Reporter: wimh | Owner: gjm
Type: defect | Status: accepted
Priority: major | Milestone: Release 9
Component: relations | Version: 0.8.0dev
Resolution: | Keywords:
------------------------+-----------------------
Comment (by wimh):
After patching bh_ticket.html relations are visible for the anonymous
user. Great, thanks for that!
The change in widget_relations.html does hide the "Manage relations"
button, but after logging in, it is still not visible.
,,OT: email notifications seems broken. I did not get an email
notification of the previous comment.,,
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/813#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #813: TICKET_VIEW is not sufficient to see
relations
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#813: TICKET_VIEW is not sufficient to see relations
------------------------+-----------------------
Reporter: wimh | Owner: gjm
Type: defect | Status: closed
Priority: major | Milestone: Release 9
Component: relations | Version: 0.8.0dev
Resolution: fixed | Keywords:
------------------------+-----------------------
Changes (by gjm):
* status: accepted => closed
* resolution: => fixed
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/813#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #813: TICKET_VIEW is not sufficient to see
relations
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#813: TICKET_VIEW is not sufficient to see relations
------------------------+-----------------------
Reporter: wimh | Owner: gjm
Type: defect | Status: accepted
Priority: major | Milestone: Release 9
Component: relations | Version: 0.8.0dev
Resolution: | Keywords:
------------------------+-----------------------
Changes (by gjm):
* owner: nobody => gjm
* status: new => accepted
Comment:
It looks like the {{{has_property_editor}}} is on the wrong element. My
best guess is that the following will fix this issue.
{{{#!diff
Index:
bloodhound_dashboard/bhdashboard/widgets/templates/widget_relations.html
===================================================================
---
bloodhound_dashboard/bhdashboard/widgets/templates/widget_relations.html
(revision 1685407)
+++
bloodhound_dashboard/bhdashboard/widgets/templates/widget_relations.html
(working copy)
@@ -64,7 +64,7 @@
</py:otherwise>
</py:choose>
- <div class="btn-group">
+ <div py:if="has_property_editor" class="btn-group">
<form method="get" action="${href.ticket(ticket.id, 'relations')}">
<button type="submit" class="btn" id="manage-relations"><i class
="icon-retweet"></i> Manage relations</button>
</form>
Index: bloodhound_theme/bhtheme/templates/bh_ticket.html
===================================================================
--- bloodhound_theme/bhtheme/templates/bh_ticket.html (revision 1685407)
+++ bloodhound_theme/bhtheme/templates/bh_ticket.html (working copy)
@@ -445,7 +445,7 @@
</div>
</form>
- <div py:if="bhrelations and ticket.exists and
has_property_editor" class="relations">
+ <div py:if="bhrelations and ticket.exists" class="relations">
<bh:widget urn="TicketRelations">
<bh:args>
<bh:arg name="tid">$ticket.id</bh:arg>
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/813#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #813: TICKET_VIEW is not sufficient to see
relations
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#813: TICKET_VIEW is not sufficient to see relations
------------------------+-----------------------
Reporter: wimh | Owner: nobody
Type: defect | Status: new
Priority: major | Milestone: Release 9
Component: relations | Version: 0.8.0dev
Resolution: | Keywords:
------------------------+-----------------------
Changes (by rjollos):
* milestone: => Release 9
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/813#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker