[GitHub] wolfmanfx opened a new pull request #545: Patch for https://github.com/apache/cordova-ios/issues/538

[GitBox <gi...@apache.org>]

wolfmanfx opened a new pull request #545: Patch for https://github.com/apache/cordova-ios/issues/538
URL: https://github.com/apache/cordova-ios/pull/545
 
 
   …th the old behavior it were not possible to add apple watch targets and build it because cordova bricked the bundleids for these targets.
   
   * Add new build parameter multipleProvisioningProfiles. Here the usage within the build.json:
   
               "multipleProvisioningProfiles": [
                   { "key": "de.demo.html5", "value": "DemoME-Enterprise" },
                   { "key": "de.demo.html5.watchkitapp", "value": "DemoWE-Enterprise" },
                   { "key": "de.demo.html5.watchkitapp.watchkitextension", "value": "DemoWE Extension-Enterprise" }
               ],
   
   This one is needed too otherwise the signing step fails because cordova generates a wrong bundleid to prov.profile mapping. With these settings the exportOptions.plist is written correctly for multiple targets.
   This patch is needed to make the apple watch targets work with the cordova-ios workflow (apple watch targets added within a post process scripts using npm xcode)
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   When cordova (using 5.0.0) projects contains watch targets (watchkit, watch extension) which have their own bundle id setup correctly, cordova overwrites all targets with the same id.
   So the motivation is clear to have an hybrid app as watchos host without maintaining a manual created xcode project.
   
   
   
   ### Description
   See commit message
   
   
   
   ### Testing
   Tested against a real project with an watchos app.
   
   
   
   ### Checklist
   
   - [ X] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ X] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org