[GitHub] [pinot] walterddr commented on a change in pull request #7719: add a build/ folder symlink to bin_dist

[GitBox <gi...@apache.org>]

walterddr commented on a change in pull request #7719:
URL: https://github.com/apache/pinot/pull/7719#discussion_r797122464



##########
File path: pinot-distribution/pom.xml
##########
@@ -262,6 +262,43 @@
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-enforcer-plugin</artifactId>
           </plugin>
+          <!-- Create symlink "build" to the root directory (Unix only) -->
+          <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>exec-maven-plugin</artifactId>
+            <version>1.5.0</version>
+            <executions>
+              <execution>
+                <id>remove-build-directory</id>
+                <phase>clean</phase>

Review comment:
       i haven't tested this but removing symlinks before recreating it will do no harm anyways. let's keep this 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org