You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Shwetha GS <ss...@hortonworks.com> on 2016/08/08 10:59:33 UTC
Review Request 50890: ATLAS-1104 Get outgoing edges by label doesn't
work in some cases
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50890/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1104
https://issues.apache.org/jira/browse/ATLAS-1104
Repository: atlas
Description
-------
Get edges by label replaced with traverse through get edges
Diffs
-----
repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java 351bd12
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 81fb76e
repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 69223f5
repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3a5829b
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 9bd3682
repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java 8a0a6bc
Diff: https://reviews.apache.org/r/50890/diff/
Testing
-------
UTs
Thanks,
Shwetha GS
Re: Review Request 50890: ATLAS-1104 Get outgoing edges by label
doesn't work in some cases
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50890/#review145131
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 198)
<https://reviews.apache.org/r/50890/#comment211304>
Will have to make similiar changes to change method calls to GraphHelper.getOutgoingEdgesByLabel in
1. public Edge getOrCreateEdge(Vertex outVertex, Vertex inVertex, String edgeLabel) {
Iterable<Edge> edges = inVertex.getEdges(Direction.IN, edgeLabel);
2. Titan0Vertex.getEdges(AtlasEdgeDirection dir, String edgeLabel)
- Suma Shivaprasad
On Aug. 8, 2016, 10:59 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50890/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2016, 10:59 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1104
> https://issues.apache.org/jira/browse/ATLAS-1104
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Get edges by label replaced with traverse through get edges
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java 351bd12
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 81fb76e
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 69223f5
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3a5829b
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 9bd3682
> repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java 8a0a6bc
>
> Diff: https://reviews.apache.org/r/50890/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 50890: ATLAS-1104 Get outgoing edges by label
doesn't work in some cases
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50890/#review145130
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java (line 285)
<https://reviews.apache.org/r/50890/#comment211303>
Will have to make similiar changes to change method calls to GraphHelper.getOutgoingEdgesByLabel in
1. GraphToTypedInstanceMapper.mapVertexToTraitInstance
for (Edge edge : instanceVertex.getEdges(Direction.OUT, relationshipLabel)) {
2. GraphHelper.getOrCreateEdge
public Edge getOrCreateEdge(Vertex outVertex, Vertex inVertex, String edgeLabel) {
Iterable<Edge> edges = inVertex.getEdges(Direction.IN, edgeLabel);
3. Titan0Vertex.getEdges(AtlasEdgeDirection dir, String edgeLabel)
- Suma Shivaprasad
On Aug. 8, 2016, 10:59 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50890/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2016, 10:59 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1104
> https://issues.apache.org/jira/browse/ATLAS-1104
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Get edges by label replaced with traverse through get edges
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java 351bd12
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 81fb76e
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 69223f5
> repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 3a5829b
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 9bd3682
> repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java 8a0a6bc
>
> Diff: https://reviews.apache.org/r/50890/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> Shwetha GS
>
>