Re: [PR] GH-19667: [C++][Gandiva] Replace RegexUtil out references with pointer out args [arrow]

["Reranko05 (via GitHub)" <gi...@apache.org>]

Reranko05 commented on code in PR #49879:
URL: https://github.com/apache/arrow/pull/49879#discussion_r3171986310


##########
cpp/src/gandiva/regex_util.cc:
##########
@@ -22,11 +22,11 @@ namespace gandiva {
 const std::set<char> RegexUtil::pcre_regex_specials_ = {
     '[', ']', '(', ')', '|', '^', '-', '+', '*', '?', '{', '}', '$', '\\', '.'};
 
-Status RegexUtil::SqlLikePatternToPcre(const std::string& sql_pattern, char escape_char,
-                                       std::string& pcre_pattern) {
+arrow::Result<std::string> RegexUtil::SqlLikePatternToPcre(const std::string& sql_pattern,
+                                                           char escape_char) {
   /// Characters that are considered special by pcre regex. These needs to be

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org