[GitHub] [solr] risdenk commented on a diff in pull request #585: SOLR-15955 Update Jetty dependency to 10

[GitBox <gi...@apache.org>]

risdenk commented on code in PR #585:
URL: https://github.com/apache/solr/pull/585#discussion_r1000954236


##########
versions.lock:
##########
@@ -230,30 +230,30 @@ org.codehaus.janino:commons-compiler:3.1.8 (2 constraints: 2f1983ec)
 org.codehaus.janino:janino:3.1.8 (1 constraints: 640dbc2c)
 org.codehaus.woodstox:stax2-api:4.2.1 (2 constraints: 36152eaf)
 org.codelibs:jhighlight:1.1.0 (1 constraints: 590ce401)
-org.eclipse.jetty:jetty-alpn-client:9.4.48.v20220622 (2 constraints: 5025331d)
-org.eclipse.jetty:jetty-alpn-java-client:9.4.48.v20220622 (1 constraints: 7f07517d)
-org.eclipse.jetty:jetty-alpn-java-server:9.4.48.v20220622 (1 constraints: 7f07517d)
-org.eclipse.jetty:jetty-alpn-server:9.4.48.v20220622 (2 constraints: 211bb2dd)
-org.eclipse.jetty:jetty-client:9.4.48.v20220622 (2 constraints: 4b1fb13f)
-org.eclipse.jetty:jetty-continuation:9.4.48.v20220622 (3 constraints: cc332338)
-org.eclipse.jetty:jetty-deploy:9.4.48.v20220622 (1 constraints: 7f07517d)
-org.eclipse.jetty:jetty-http:9.4.48.v20220622 (5 constraints: 8649704d)
-org.eclipse.jetty:jetty-io:9.4.48.v20220622 (8 constraints: 077ef92c)
-org.eclipse.jetty:jetty-jmx:9.4.48.v20220622 (1 constraints: 7f07517d)
-org.eclipse.jetty:jetty-rewrite:9.4.48.v20220622 (1 constraints: 7f07517d)
-org.eclipse.jetty:jetty-security:9.4.48.v20220622 (2 constraints: e817f7dd)
-org.eclipse.jetty:jetty-server:9.4.48.v20220622 (7 constraints: 2a7af2e8)
-org.eclipse.jetty:jetty-servlet:9.4.48.v20220622 (2 constraints: 621757bf)
-org.eclipse.jetty:jetty-servlets:9.4.48.v20220622 (1 constraints: 7f07517d)
-org.eclipse.jetty:jetty-util:9.4.48.v20220622 (9 constraints: d490c7eb)
-org.eclipse.jetty:jetty-util-ajax:9.4.48.v20220622 (1 constraints: 6a106ee2)
-org.eclipse.jetty:jetty-webapp:9.4.48.v20220622 (2 constraints: 70175dc0)
-org.eclipse.jetty:jetty-xml:9.4.48.v20220622 (3 constraints: 5327b11f)
-org.eclipse.jetty.http2:http2-client:9.4.48.v20220622 (2 constraints: 4b1fb13f)
-org.eclipse.jetty.http2:http2-common:9.4.48.v20220622 (3 constraints: 212b1b1f)
-org.eclipse.jetty.http2:http2-hpack:9.4.48.v20220622 (2 constraints: 4e19575c)
-org.eclipse.jetty.http2:http2-http-client-transport:9.4.48.v20220622 (1 constraints: 7f07517d)
-org.eclipse.jetty.http2:http2-server:9.4.48.v20220622 (1 constraints: 7f07517d)
+org.eclipse.jetty:jetty-alpn-client:10.0.8 (3 constraints: 672ec0e8)
+org.eclipse.jetty:jetty-alpn-java-client:10.0.8 (2 constraints: c31a2343)
+org.eclipse.jetty:jetty-alpn-java-server:10.0.8 (1 constraints: 3b052f3b)
+org.eclipse.jetty:jetty-alpn-server:10.0.8 (2 constraints: 9916c323)
+org.eclipse.jetty:jetty-client:10.0.8 (2 constraints: c31a2343)
+org.eclipse.jetty:jetty-continuation:9.4.42.v20210604 (1 constraints: 721b9cb8)

Review Comment:
   This needs to be fixed.



##########
solr/solrj/build.gradle:
##########
@@ -75,6 +76,7 @@ dependencies {
   testImplementation 'commons-io:commons-io'
 
   testImplementation 'javax.servlet:javax.servlet-api'

Review Comment:
   I see there is a comment thread elsewhere on this in the PR.



##########
solr/solrj/build.gradle:
##########
@@ -75,6 +76,7 @@ dependencies {
   testImplementation 'commons-io:commons-io'
 
   testImplementation 'javax.servlet:javax.servlet-api'

Review Comment:
   Not sure we need both `'javax.servlet:javax.servlet-api'` and `'org.eclipse.jetty.toolchain:jetty-servlet-api'`? I need to check this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org