[GitHub] [superset] eschutho commented on a change in pull request #17385: fix(sql lab): NULL styling in grid cell

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #17385:
URL: https://github.com/apache/superset/pull/17385#discussion_r746167969



##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -426,14 +426,7 @@ export default class FilterableTable extends PureComponent<
   }) {
     const columnKey = this.props.orderedColumnKeys[columnIndex];
     const cellData = this.list[rowIndex][columnKey];
-    const content =
-      cellData === null ? (
-        <i className="text-muted">
-          {this.getCellContent({ cellData, columnKey })}
-        </i>
-      ) : (
-        this.getCellContent({ cellData, columnKey })
-      );

Review comment:
       do we still need this if the table has more than 50 columns? (i.e., renders a grid?)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org