You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by al...@apache.org on 2021/06/30 12:02:37 UTC

[dubbo-getty] branch improve/delte-handleLoop updated: feat: go fmt

This is an automated email from the ASF dual-hosted git repository.

alexstocks pushed a commit to branch improve/delte-handleLoop
in repository https://gitbox.apache.org/repos/asf/dubbo-getty.git


The following commit(s) were added to refs/heads/improve/delte-handleLoop by this push:
     new 372309a  feat: go fmt
     new 87189d1  Merge pull request #65 from georgehao/improve/delte-handleLoop
372309a is described below

commit 372309a41d3942e4043d4d5d3b644a12bb29548c
Author: georgehao <ha...@gmail.com>
AuthorDate: Wed Jun 30 19:59:24 2021 +0800

    feat: go fmt
---
 benchmark/client/main.go        | 13 +++++++------
 benchmark/loop_client/main.go   | 12 +++++++-----
 benchmark/server/main.go        |  8 +++-----
 connection.go                   |  8 ++------
 demo/hello/tls/server/server.go |  2 +-
 session.go                      |  4 +---
 6 files changed, 21 insertions(+), 26 deletions(-)

diff --git a/benchmark/client/main.go b/benchmark/client/main.go
index 607e9af..2484cfb 100644
--- a/benchmark/client/main.go
+++ b/benchmark/client/main.go
@@ -48,8 +48,10 @@ var (
 
 var taskPool gxsync.GenericTaskPool
 
-const CronPeriod = 20e9
-const WritePkgTimeout = 1e8
+const (
+	CronPeriod      = 20e9
+	WritePkgTimeout = 1e8
+)
 
 func main() {
 	flag.Parse()
@@ -80,9 +82,9 @@ func main() {
 			)
 
 			var tmpSession getty.Session
-			var NewHelloClientSession = func(session getty.Session) (err error) {
-				var pkgHandler = &PackageHandler{}
-				var EventListener = &MessageHandler{}
+			NewHelloClientSession := func(session getty.Session) (err error) {
+				pkgHandler := &PackageHandler{}
+				EventListener := &MessageHandler{}
 
 				EventListener.SessionOnOpen = func(session getty.Session) {
 					tmpSession = session
@@ -173,7 +175,6 @@ func main() {
 	log.Printf("throughput  (TPS)    : %d\n", int64(n*m)*1000/totalT)
 	log.Printf("mean: %.f ns, median: %.f ns, max: %.f ns, min: %.f ns, p99: %.f ns\n", mean, median, max, min, p99)
 	log.Printf("mean: %d ms, median: %d ms, max: %d ms, min: %d ms, p99: %d ms\n", int64(mean/1000000), int64(median/1000000), int64(max/1000000), int64(min/1000000), int64(p99/1000000))
-
 }
 
 type MessageHandler struct {
diff --git a/benchmark/loop_client/main.go b/benchmark/loop_client/main.go
index 72369bc..60d6dc9 100644
--- a/benchmark/loop_client/main.go
+++ b/benchmark/loop_client/main.go
@@ -45,8 +45,10 @@ var (
 
 var taskPool gxsync.GenericTaskPool
 
-const CronPeriod = 20e9
-const WritePkgTimeout = 1e8
+const (
+	CronPeriod      = 20e9
+	WritePkgTimeout = 1e8
+)
 
 func main() {
 	flag.Parse()
@@ -63,9 +65,9 @@ func main() {
 			)
 
 			var tmpSession getty.Session
-			var NewHelloClientSession = func(session getty.Session) (err error) {
-				var pkgHandler = &PackageHandler{}
-				var EventListener = &MessageHandler{}
+			NewHelloClientSession := func(session getty.Session) (err error) {
+				pkgHandler := &PackageHandler{}
+				EventListener := &MessageHandler{}
 
 				EventListener.SessionOnOpen = func(session getty.Session) {
 					tmpSession = session
diff --git a/benchmark/server/main.go b/benchmark/server/main.go
index 9789e54..48b9f44 100644
--- a/benchmark/server/main.go
+++ b/benchmark/server/main.go
@@ -43,9 +43,7 @@ var (
 	pprofPort    = flag.Int("pprof_port", 65432, "pprof http port")
 )
 
-var (
-	taskPool gxsync.GenericTaskPool
-)
+var taskPool gxsync.GenericTaskPool
 
 const CronPeriod = 20e9
 
@@ -75,8 +73,8 @@ func main() {
 }
 
 func NewHelloServerSession(session getty.Session) (err error) {
-	var pkgHandler = &PackageHandler{}
-	var EventListener = &MessageHandler{}
+	pkgHandler := &PackageHandler{}
+	EventListener := &MessageHandler{}
 
 	tcpConn, ok := session.Conn().(*net.TCPConn)
 	if !ok {
diff --git a/connection.go b/connection.go
index 4463804..d37f532 100644
--- a/connection.go
+++ b/connection.go
@@ -34,17 +34,13 @@ import (
 	uatomic "go.uber.org/atomic"
 )
 
-var (
-	launchTime = time.Now()
-)
+var launchTime = time.Now()
 
 /////////////////////////////////////////
 // getty connection
 /////////////////////////////////////////
 
-var (
-	connID uatomic.Uint32
-)
+var connID uatomic.Uint32
 
 type gettyConn struct {
 	id            uint32
diff --git a/demo/hello/tls/server/server.go b/demo/hello/tls/server/server.go
index c73d02c..1f9f637 100644
--- a/demo/hello/tls/server/server.go
+++ b/demo/hello/tls/server/server.go
@@ -28,8 +28,8 @@ import (
 
 import (
 	"github.com/apache/dubbo-getty"
-	"github.com/apache/dubbo-getty/demo/util"
 	tls "github.com/apache/dubbo-getty/demo/hello/tls"
+	"github.com/apache/dubbo-getty/demo/util"
 )
 
 var (
diff --git a/session.go b/session.go
index 4fa5a02..b55407c 100644
--- a/session.go
+++ b/session.go
@@ -58,9 +58,7 @@ const (
 // session
 /////////////////////////////////////////
 
-var (
-	defaultTimerWheel *gxtime.TimerWheel
-)
+var defaultTimerWheel *gxtime.TimerWheel
 
 func init() {
 	gxtime.InitDefaultTimerWheel()