(shardingsphere) branch master updated: Add more test cases on HintInlineShardingAlgorithm (#33701)

[zh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 1c347f50c17 Add more test cases on HintInlineShardingAlgorithm (#33701)
1c347f50c17 is described below

commit 1c347f50c17f834fa74d3fcb1aac1602281209f0
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Mon Nov 18 12:01:17 2024 +0800

    Add more test cases on HintInlineShardingAlgorithm (#33701)
---
 .../sharding/hint/HintInlineShardingAlgorithmTest.java  | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/algorithm/sharding/hint/HintInlineShardingAlgorithmTest.java b/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/algorithm/sharding/hint/HintInlineShardingAlgorithmTest.java
index a48959579af..7e3c4530fbd 100644
--- a/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/algorithm/sharding/hint/HintInlineShardingAlgorithmTest.java
+++ b/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/algorithm/sharding/hint/HintInlineShardingAlgorithmTest.java
@@ -29,30 +29,27 @@ import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
-import java.util.Properties;
 
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.MatcherAssert.assertThat;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 class HintInlineShardingAlgorithmTest {
     
     private HintInlineShardingAlgorithm hintInlineShardingAlgorithm;
     
-    private HintInlineShardingAlgorithm hintInlineShardingAlgorithmDefault;
-    
     @BeforeEach
     void setUp() {
         hintInlineShardingAlgorithm = (HintInlineShardingAlgorithm) TypedSPILoader.getService(ShardingAlgorithm.class,
                 "HINT_INLINE", PropertiesBuilder.build(new Property("algorithm-expression", "t_order_$->{value % 4}")));
-        hintInlineShardingAlgorithmDefault = new HintInlineShardingAlgorithm();
-        hintInlineShardingAlgorithmDefault.init(new Properties());
     }
     
     @Test
-    void assertDoShardingWithSingleValueOfDefault() {
+    void assertDoShardingWithEmptyValue() {
         List<String> availableTargetNames = Arrays.asList("t_order_0", "t_order_1", "t_order_2", "t_order_3");
-        HintShardingValue<Comparable<?>> shardingValue = new HintShardingValue<>("t_order", "order_id", Collections.singleton("t_order_0"));
-        Collection<String> actual = hintInlineShardingAlgorithmDefault.doSharding(availableTargetNames, shardingValue);
-        assertTrue(actual.contains("t_order_0"));
+        HintShardingValue<Comparable<?>> shardingValue = new HintShardingValue<>("t_order", "order_id", Collections.emptyList());
+        Collection<String> actual = hintInlineShardingAlgorithm.doSharding(availableTargetNames, shardingValue);
+        assertThat(actual, is(availableTargetNames));
     }
     
     @Test
@@ -60,7 +57,7 @@ class HintInlineShardingAlgorithmTest {
         List<String> availableTargetNames = Arrays.asList("t_order_0", "t_order_1", "t_order_2", "t_order_3");
         HintShardingValue<Comparable<?>> shardingValue = new HintShardingValue<>("t_order", "order_id", Collections.singleton(4));
         Collection<String> actual = hintInlineShardingAlgorithm.doSharding(availableTargetNames, shardingValue);
-        assertTrue(actual.contains("t_order_0"));
+        assertThat(actual, is(Collections.singletonList("t_order_0")));
     }
     
     @Test