[GitHub] [spark] cloud-fan commented on a diff in pull request #40754: [SPARK-37099][SQL][FOLLOWUP] Add numOutputRows metric for WindowGroupLimitExec

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #40754:
URL: https://github.com/apache/spark/pull/40754#discussion_r1164880978


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowGroupLimitExec.scala:
##########
@@ -116,7 +129,8 @@ abstract class BaseLimitIterator extends Iterator[InternalRow] {
 
 case class SimpleLimitIterator(
     input: Iterator[InternalRow],
-    limit: Int) extends BaseLimitIterator {
+    limit: Int,
+    numOutputRows: SQLMetric) extends BaseLimitIterator {

Review Comment:
   `override lazy val metrics` must be put in a `SparkPlan`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org