You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Donald Woods <dw...@apache.org> on 2007/05/22 17:38:22 UTC

Re: svn commit: r540409 - in /geronimo/server/trunk: assemblies/geronimo-boilerplate-minimal/pom.xml pom.xml

Can we put the addition of Xerces/Xalan in geronimo-boilerplate-jee5 instead 
of geronimo-boilerplate-minimal, which adds unnecessary bloat back into the 
minimal assemblies again?

-Donald

kevan@apache.org wrote:
> Author: kevan
> Date: Mon May 21 20:18:08 2007
> New Revision: 540409
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=540409
> Log:
> GERONIMO-3180 Override XML Parsing bugs in JRE 1.5 by providing our own xerces and xalan jars in lib/endorsed. Once JRE issues are resolved, we can consider removing these jars
> 
> Modified:
>     geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/pom.xml
>     geronimo/server/trunk/pom.xml
> 
> Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/pom.xml?view=diff&rev=540409&r1=540408&r2=540409
> ==============================================================================
> --- geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/pom.xml (original)
> +++ geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/pom.xml Mon May 21 20:18:08 2007
> @@ -122,6 +122,19 @@
>                                      <groupId>org.apache.yoko</groupId>
>                                      <artifactId>yoko-rmi-spec</artifactId>
>                                  </artifactItem>
> +                                <!-- Added by G3180 to fix XML parsing issues in JRE 1.5_07 -> 1.5_11.  If problem is fixed, these 3 jars can be removed from lib/endorsed -->
> +                                <artifactItem>
> +                                    <groupId>xalan</groupId>
> +                                    <artifactId>xalan</artifactId>
> +                                </artifactItem>
> +                                <artifactItem>
> +                                    <groupId>xerces</groupId>
> +                                    <artifactId>xercesImpl</artifactId>
> +                                </artifactItem>
> +                                <artifactItem>
> +                                    <groupId>xml-apis</groupId>
> +                                    <artifactId>xml-apis</artifactId>
> +                                </artifactItem>
>                              </artifactItems>
>                              <outputDirectory>${project.build.directory}/classes/lib/endorsed</outputDirectory>
>                          </configuration>
> 
> Modified: geronimo/server/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/pom.xml?view=diff&rev=540409&r1=540408&r2=540409
> ==============================================================================
> --- geronimo/server/trunk/pom.xml (original)
> +++ geronimo/server/trunk/pom.xml Mon May 21 20:18:08 2007
> @@ -525,7 +525,7 @@
>              <dependency>
>                  <groupId>xalan</groupId>
>                  <artifactId>xalan</artifactId>
> -                <version>2.6.0</version>
> +                <version>2.7.0</version>
>              </dependency>
>  
>              <dependency>
> 
> 
> 
> 

Re: svn commit: r540409 - in /geronimo/server/trunk: assemblies/geronimo-boilerplate-minimal/pom.xml pom.xml

Posted by Donald Woods <dw...@apache.org>.
If the XML failures are in TCK tests that relate to modules not included in 
the minimal assemblies, then what would we be breaking by removing Xerces/Xalan?

I was just hoping that we could keep them out of the minimal assemblies if 
they are not needed, since some users will want to use Java 5 and others are 
wanting Java 6 support, which both provide their own implementations at 
different feature levels....


-Donald


Kevan Miller wrote:
> 
> On May 22, 2007, at 11:38 AM, Donald Woods wrote:
> 
>> Can we put the addition of Xerces/Xalan in geronimo-boilerplate-jee5 
>> instead of geronimo-boilerplate-minimal, which adds unnecessary bloat 
>> back into the minimal assemblies again?
> 
> We could consider it. Putting them back into boilerplate-minimal was 
> consistent with our G 1.1 and 1.2 structure. I certainly wouldn't call 
> it "unecessary" and could do without painting the issue with words like 
> "bloat". I could similarly describe your proposal as -- "could we remove 
> Xerces/Xalan from the minimal server, so that we can break xml 
> processing in that environment?
> 
> Good chance that we'll be pulling the xalan jar out, for other reasons. 
> Since xalan is the biggest jar, I assume this helps?
> 
> --kevan
> 
> 

Re: svn commit: r540409 - in /geronimo/server/trunk: assemblies/geronimo-boilerplate-minimal/pom.xml pom.xml

Posted by Kevan Miller <ke...@gmail.com>.
On May 22, 2007, at 11:38 AM, Donald Woods wrote:

> Can we put the addition of Xerces/Xalan in geronimo-boilerplate- 
> jee5 instead of geronimo-boilerplate-minimal, which adds  
> unnecessary bloat back into the minimal assemblies again?

We could consider it. Putting them back into boilerplate-minimal was  
consistent with our G 1.1 and 1.2 structure. I certainly wouldn't  
call it "unecessary" and could do without painting the issue with  
words like "bloat". I could similarly describe your proposal as --  
"could we remove Xerces/Xalan from the minimal server, so that we can  
break xml processing in that environment?

Good chance that we'll be pulling the xalan jar out, for other  
reasons. Since xalan is the biggest jar, I assume this helps?

--kevan