[GitHub] [accumulo] dlmarion commented on a change in pull request #2399: Make SplitLarge implement KeywordExecutable

[GitBox <gi...@apache.org>]

dlmarion commented on a change in pull request #2399:
URL: https://github.com/apache/accumulo/pull/2399#discussion_r774205628



##########
File path: core/src/main/java/org/apache/accumulo/core/file/rfile/SplitLarge.java
##########
@@ -53,10 +56,25 @@
   }
 
   public static void main(String[] args) throws Exception {
+    new SplitLarge().execute(args);
+  }
+
+  @Override
+  public String keyword() {
+    return "split-large";
+  }
+
+  @Override
+  public String description() {
+    return "Splits an RFile into large and small key/value files";
+  }
+
+  @Override
+  public void execute(String[] args) throws Exception {
     Configuration conf = new Configuration();
     FileSystem fs = FileSystem.get(conf);
     Opts opts = new Opts();
-    opts.parseArgs(SplitLarge.class.getName(), args);
+    opts.parseArgs("accumulo split-large", args);

Review comment:
       I just followed what was done in CreateToken 😀




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org