You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@artemis.apache.org by jb...@apache.org on 2026/06/30 18:19:25 UTC

(artemis) branch main updated: ARTEMIS-6134 Bump activemq5-version from 5.19.7 to 5.19.8

This is an automated email from the ASF dual-hosted git repository.

jbertram pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/artemis.git


The following commit(s) were added to refs/heads/main by this push:
     new a0069f77ee ARTEMIS-6134 Bump activemq5-version from 5.19.7 to 5.19.8
a0069f77ee is described below

commit a0069f77ee168cf977f48737d713652555d7c9fa
Author: Justin Bertram <jb...@apache.org>
AuthorDate: Tue Jun 30 12:17:40 2026 -0500

    ARTEMIS-6134 Bump activemq5-version from 5.19.7 to 5.19.8
---
 pom.xml                                            |  2 +-
 .../artemiswrapper/ArtemisBrokerWrapper.java       |  5 +++++
 .../broker/region/policy/DestinationProxy.java     |  5 +++++
 .../broker/region/policy/RegionBrokerProxy.java    |  5 +++++
 .../apache/activemq/JmsTempDestinationTest.java    |  4 ++--
 .../activemq/ActiveMQConnectionAccessor.java       | 23 ++++++++++++++++++++++
 .../integration/openwire/SimpleOpenWireTest.java   |  7 ++++---
 7 files changed, 45 insertions(+), 6 deletions(-)

diff --git a/pom.xml b/pom.xml
index 83cb905d58..757c0427b5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -95,7 +95,7 @@
       <pax.exam.version>4.14.0</pax.exam.version>
       <commons.config.version>2.15.1</commons.config.version>
       <commons.lang.version>3.20.0</commons.lang.version>
-      <activemq5-version>5.19.7</activemq5-version>
+      <activemq5-version>5.19.8</activemq5-version>
       <apache.derby.version>10.15.2.0</apache.derby.version>
       <commons.beanutils.version>1.11.0</commons.beanutils.version>
       <commons.logging.version>1.4.0</commons.logging.version>
diff --git a/tests/activemq5-unit-tests/src/main/java/org/apache/activemq/broker/artemiswrapper/ArtemisBrokerWrapper.java b/tests/activemq5-unit-tests/src/main/java/org/apache/activemq/broker/artemiswrapper/ArtemisBrokerWrapper.java
index bf1da2c1ca..f47c2bc23c 100644
--- a/tests/activemq5-unit-tests/src/main/java/org/apache/activemq/broker/artemiswrapper/ArtemisBrokerWrapper.java
+++ b/tests/activemq5-unit-tests/src/main/java/org/apache/activemq/broker/artemiswrapper/ArtemisBrokerWrapper.java
@@ -183,6 +183,11 @@ public class ArtemisBrokerWrapper extends ArtemisBrokerBase {
 
    }
 
+   @Override
+   public void messageNoConsumers(ConnectionContext context, MessageReference messageReference) {
+
+   }
+
    private void addServerAcceptor(Configuration serverConfig, BrokerService.ConnectorInfo info) throws Exception {
       serverConfig.addAcceptorConfiguration("homePort" + info.uri.getPort(), info.uri.toString());
    }
diff --git a/tests/activemq5-unit-tests/src/main/java/org/apache/activemq/broker/region/policy/DestinationProxy.java b/tests/activemq5-unit-tests/src/main/java/org/apache/activemq/broker/region/policy/DestinationProxy.java
index 5754eea001..46764a1683 100644
--- a/tests/activemq5-unit-tests/src/main/java/org/apache/activemq/broker/region/policy/DestinationProxy.java
+++ b/tests/activemq5-unit-tests/src/main/java/org/apache/activemq/broker/region/policy/DestinationProxy.java
@@ -57,6 +57,11 @@ public class DestinationProxy implements Destination {
 
    // Destination
 
+   @Override
+   public int getMaxInflatedDataSize() {
+      throw new UnsupportedOperationException("Not implemented yet");
+   }
+
    @Override
    public void addSubscription(ConnectionContext context, Subscription sub) throws Exception {
       throw new UnsupportedOperationException("Not implemented yet");
diff --git a/tests/activemq5-unit-tests/src/main/java/org/apache/activemq/broker/region/policy/RegionBrokerProxy.java b/tests/activemq5-unit-tests/src/main/java/org/apache/activemq/broker/region/policy/RegionBrokerProxy.java
index f6664ae6cd..6fda8bd5c0 100644
--- a/tests/activemq5-unit-tests/src/main/java/org/apache/activemq/broker/region/policy/RegionBrokerProxy.java
+++ b/tests/activemq5-unit-tests/src/main/java/org/apache/activemq/broker/region/policy/RegionBrokerProxy.java
@@ -407,6 +407,11 @@ public class RegionBrokerProxy implements Broker {
       throw new UnsupportedOperationException("Not implemented yet");
    }
 
+   @Override
+   public void messageNoConsumers(ConnectionContext context, MessageReference messageReference) {
+      throw new UnsupportedOperationException("Not implemented yet");
+   }
+
    @Override
    public void nowMasterBroker() {
       throw new UnsupportedOperationException("Not implemented yet");
diff --git a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/JmsTempDestinationTest.java b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/JmsTempDestinationTest.java
index f74ed07e0f..d0c0fefdb3 100644
--- a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/JmsTempDestinationTest.java
+++ b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/JmsTempDestinationTest.java
@@ -198,7 +198,7 @@ public class JmsTempDestinationTest {
       final TemporaryQueue queue = tempSession.createTemporaryQueue();
 
       final ActiveMQConnection activeMQConnection = (ActiveMQConnection) connection;
-      Assert.assertTrue("creation advisory received in time with async dispatch", Wait.waitFor(() -> activeMQConnection.activeTempDestinations.containsKey(queue)));
+      Assert.assertTrue("creation advisory received in time with async dispatch", Wait.waitFor(() -> activeMQConnection.activeTempDestinations.contains(queue)));
 
       // This message delivery should work since the temp connection is still
       // open.
@@ -242,7 +242,7 @@ public class JmsTempDestinationTest {
       final TemporaryQueue queue = tempSession.createTemporaryQueue();
 
       final ActiveMQConnection activeMQConnection = (ActiveMQConnection) connection;
-      Assert.assertTrue("creation advisory received in time with async dispatch", Wait.waitFor(() -> activeMQConnection.activeTempDestinations.containsKey(queue)));
+      Assert.assertTrue("creation advisory received in time with async dispatch", Wait.waitFor(() -> activeMQConnection.activeTempDestinations.contains(queue)));
 
       // This message delivery should work since the temp connection is still
       // open.
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/ActiveMQConnectionAccessor.java b/tests/integration-tests/src/test/java/org/apache/activemq/ActiveMQConnectionAccessor.java
new file mode 100644
index 0000000000..b75afc0b3a
--- /dev/null
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/ActiveMQConnectionAccessor.java
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq;
+
+public class ActiveMQConnectionAccessor {
+   public static int getActiveTempDestinationsSize(ActiveMQConnection connection) {
+      return connection.activeTempDestinations.size();
+   }
+}
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/SimpleOpenWireTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/SimpleOpenWireTest.java
index c353953c5b..10439279b4 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/SimpleOpenWireTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/SimpleOpenWireTest.java
@@ -87,6 +87,7 @@ import org.junit.jupiter.api.Test;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import static org.apache.activemq.ActiveMQConnectionAccessor.getActiveTempDestinationsSize;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -784,7 +785,7 @@ public class SimpleOpenWireTest extends BasicOpenWireTest {
          TopicPublisher publisher = newTopicSession.createPublisher(tempTopic);
 
          // need to wait here because the ActiveMQ client's temp destination map is updated asynchronously, not waiting can introduce a race
-         assertTrue(Wait.waitFor(() -> newConn.activeTempDestinations.size() == 1, 2000, 100));
+         assertTrue(Wait.waitFor(() -> getActiveTempDestinationsSize(newConn) == 1, 2000, 100));
 
          TextMessage msg = newTopicSession.createTextMessage("Test Message");
 
@@ -1685,7 +1686,7 @@ public class SimpleOpenWireTest extends BasicOpenWireTest {
          MessageProducer producer = session2.createProducer(tempQueue);
 
          // need to wait here because the ActiveMQ client's temp destination map is updated asynchronously, not waiting can introduce a race
-         assertTrue(Wait.waitFor(() -> ((ActiveMQConnection)connection2).activeTempDestinations.size() == 1, 2000, 100));
+         assertTrue(Wait.waitFor(() -> getActiveTempDestinationsSize((ActiveMQConnection) connection2) == 1, 2000, 100));
 
          producer.setDeliveryMode(DeliveryMode.NON_PERSISTENT);
          TextMessage m = session2.createTextMessage("Hello temp queue");
@@ -1700,7 +1701,7 @@ public class SimpleOpenWireTest extends BasicOpenWireTest {
          connection1.close();
 
          // need to wait here because the ActiveMQ client's temp destination map is updated asynchronously, not waiting can introduce a race
-         assertTrue(Wait.waitFor(() -> ((ActiveMQConnection) connection2).activeTempDestinations.isEmpty(), 2000, 100));
+         assertTrue(Wait.waitFor(() -> getActiveTempDestinationsSize((ActiveMQConnection) connection2) == 0, 2000, 100));
 
          waitForBindings(this.server, tempQueue.getQueueName(), true, 0, 0, 5000);
          //send again


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@artemis.apache.org
For additional commands, e-mail: commits-help@artemis.apache.org