[GitHub] [spark] rdblue commented on a change in pull request #24029: SPARK-27108: Add parsed SQL plans for create, CTAS.

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #24029: SPARK-27108: Add parsed SQL plans for create, CTAS.
URL: https://github.com/apache/spark/pull/24029#discussion_r265335076
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
 ##########
 @@ -1860,4 +1861,193 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
     val structField = StructField(identifier.getText, typedVisit(dataType), nullable = true)
     if (STRING == null) structField else structField.withComment(string(STRING))
   }
+
+  /**
 
 Review comment:
   Yes, this is moving what is needed from `SparkSqlAstBuilder`. The only real changes are in the `visitCreateTable` method.
   
   These rules should have already been in the abstract class. I'm not sure why they were in `SparkSqlAstBuilder` other than that was the easiest place to put them when they were added.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org