Re: [PR] GH-3223: Implement Variant parquet writer [parquet-java]

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #3221:
URL: https://github.com/apache/parquet-java/pull/3221#discussion_r2130557245


##########
parquet-avro/src/test/java/org/apache/parquet/avro/AvroTestUtil.java:
##########
@@ -129,4 +130,36 @@ public static Configuration conf(String name, boolean value) {
     conf.setBoolean(name, value);
     return conf;
   }
+
+  /**
+   * Assert that to Variant values are logically equivalent.
+   * E.g. object fields may be ordered differently in the binary.

Review Comment:
   Do you mean values? The fields themselves must have the same order because the ID list must be in lexicographical order with respect to the keys.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org