You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Syed S. Albiz (JIRA)" <ji...@apache.org> on 2011/08/02 02:40:27 UTC
[jira] [Created] (HIVE-2331) Turn off compression when generating
index intermediate results
Turn off compression when generating index intermediate results
---------------------------------------------------------------
Key: HIVE-2331
URL: https://issues.apache.org/jira/browse/HIVE-2331
Project: Hive
Issue Type: Bug
Reporter: Syed S. Albiz
HiveIndexResult is not compression-aware, so for any index to work (regardless of compact/bitmap) we need to not compress the index intermediate file when we generate it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2331) Turn off compression when generating
index intermediate results
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13075986#comment-13075986 ]
jiraposter@reviews.apache.org commented on HIVE-2331:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1254/
-----------------------------------------------------------
Review request for hive and John Sichi.
Summary
-------
add a parameter to the hiveConf when generating the index query to ensure that the output is uncompressed
This addresses bug HIVE-2331.
https://issues.apache.org/jira/browse/HIVE-2331
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java 8f185be
ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java ff9c4cc
ql/src/test/queries/clientpositive/index_bitmap_compression.q PRE-CREATION
ql/src/test/queries/clientpositive/index_compression.q PRE-CREATION
ql/src/test/results/clientpositive/index_bitmap_compression.q.out PRE-CREATION
ql/src/test/results/clientpositive/index_compression.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1254/diff
Testing
-------
added index_compression.q and index_bitmap_compression.q to test both index handlers for this case.
Thanks,
Syed
> Turn off compression when generating index intermediate results
> ---------------------------------------------------------------
>
> Key: HIVE-2331
> URL: https://issues.apache.org/jira/browse/HIVE-2331
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2331.1.patch
>
>
> HiveIndexResult is not compression-aware, so for any index to work (regardless of compact/bitmap) we need to not compress the index intermediate file when we generate it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2331) Turn off compression when generating
index intermediate results
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078366#comment-13078366 ]
jiraposter@reviews.apache.org commented on HIVE-2331:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1254/
-----------------------------------------------------------
(Updated 2011-08-02 18:58:32.937434)
Review request for hive and John Sichi.
Changes
-------
Regenerated the testcase outputs since they were mixed up previously.
Summary
-------
add a parameter to the hiveConf when generating the index query to ensure that the output is uncompressed
This addresses bug HIVE-2331.
https://issues.apache.org/jira/browse/HIVE-2331
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java c93c852
ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java f4b7c15
ql/src/test/queries/clientpositive/index_bitmap_compression.q PRE-CREATION
ql/src/test/queries/clientpositive/index_compression.q PRE-CREATION
ql/src/test/results/clientpositive/index_bitmap_compression.q.out PRE-CREATION
ql/src/test/results/clientpositive/index_compression.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1254/diff
Testing
-------
added index_compression.q and index_bitmap_compression.q to test both index handlers for this case.
Thanks,
Syed
> Turn off compression when generating index intermediate results
> ---------------------------------------------------------------
>
> Key: HIVE-2331
> URL: https://issues.apache.org/jira/browse/HIVE-2331
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2331.1.patch, HIVE-2331.2.patch
>
>
> HiveIndexResult is not compression-aware, so for any index to work (regardless of compact/bitmap) we need to not compress the index intermediate file when we generate it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2331) Turn off compression when generating
index intermediate results
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13076038#comment-13076038 ]
John Sichi commented on HIVE-2331:
----------------------------------
+1. Will commit when tests pass.
> Turn off compression when generating index intermediate results
> ---------------------------------------------------------------
>
> Key: HIVE-2331
> URL: https://issues.apache.org/jira/browse/HIVE-2331
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2331.1.patch
>
>
> HiveIndexResult is not compression-aware, so for any index to work (regardless of compact/bitmap) we need to not compress the index intermediate file when we generate it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2331) Turn off compression when generating
index intermediate results
Posted by "Syed S. Albiz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Syed S. Albiz updated HIVE-2331:
--------------------------------
Attachment: HIVE-2331.2.patch
> Turn off compression when generating index intermediate results
> ---------------------------------------------------------------
>
> Key: HIVE-2331
> URL: https://issues.apache.org/jira/browse/HIVE-2331
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2331.1.patch, HIVE-2331.2.patch
>
>
> HiveIndexResult is not compression-aware, so for any index to work (regardless of compact/bitmap) we need to not compress the index intermediate file when we generate it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2331) Turn off compression when generating
index intermediate results
Posted by "Syed S. Albiz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Syed S. Albiz updated HIVE-2331:
--------------------------------
Attachment: HIVE-2331.1.patch
fix + testcases
> Turn off compression when generating index intermediate results
> ---------------------------------------------------------------
>
> Key: HIVE-2331
> URL: https://issues.apache.org/jira/browse/HIVE-2331
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2331.1.patch
>
>
> HiveIndexResult is not compression-aware, so for any index to work (regardless of compact/bitmap) we need to not compress the index intermediate file when we generate it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2331) Turn off compression when generating
index intermediate results
Posted by "Syed S. Albiz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Syed S. Albiz updated HIVE-2331:
--------------------------------
Status: Patch Available (was: Open)
> Turn off compression when generating index intermediate results
> ---------------------------------------------------------------
>
> Key: HIVE-2331
> URL: https://issues.apache.org/jira/browse/HIVE-2331
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2331.1.patch
>
>
> HiveIndexResult is not compression-aware, so for any index to work (regardless of compact/bitmap) we need to not compress the index intermediate file when we generate it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2331) Turn off compression when generating
index intermediate results
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079169#comment-13079169 ]
Hudson commented on HIVE-2331:
------------------------------
Integrated in Hive-trunk-h0.21 #870 (See [https://builds.apache.org/job/Hive-trunk-h0.21/870/])
HIVE-2331. Turn off compression when generating index intermediate results
(Syed Albiz via jvs)
jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1153569
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java
* /hive/trunk/ql/src/test/queries/clientpositive/index_compression.q
* /hive/trunk/ql/src/test/results/clientpositive/index_compression.q.out
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java
* /hive/trunk/ql/src/test/queries/clientpositive/index_bitmap_compression.q
* /hive/trunk/ql/src/test/results/clientpositive/index_bitmap_compression.q.out
> Turn off compression when generating index intermediate results
> ---------------------------------------------------------------
>
> Key: HIVE-2331
> URL: https://issues.apache.org/jira/browse/HIVE-2331
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Fix For: 0.8.0
>
> Attachments: HIVE-2331.1.patch, HIVE-2331.2.patch
>
>
> HiveIndexResult is not compression-aware, so for any index to work (regardless of compact/bitmap) we need to not compress the index intermediate file when we generate it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2331) Turn off compression when generating
index intermediate results
Posted by "Syed S. Albiz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Syed S. Albiz updated HIVE-2331:
--------------------------------
Status: Patch Available (was: Open)
> Turn off compression when generating index intermediate results
> ---------------------------------------------------------------
>
> Key: HIVE-2331
> URL: https://issues.apache.org/jira/browse/HIVE-2331
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2331.1.patch, HIVE-2331.2.patch
>
>
> HiveIndexResult is not compression-aware, so for any index to work (regardless of compact/bitmap) we need to not compress the index intermediate file when we generate it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2331) Turn off compression when generating
index intermediate results
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-2331:
-----------------------------
Resolution: Fixed
Fix Version/s: 0.8.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Syed!
> Turn off compression when generating index intermediate results
> ---------------------------------------------------------------
>
> Key: HIVE-2331
> URL: https://issues.apache.org/jira/browse/HIVE-2331
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Fix For: 0.8.0
>
> Attachments: HIVE-2331.1.patch, HIVE-2331.2.patch
>
>
> HiveIndexResult is not compression-aware, so for any index to work (regardless of compact/bitmap) we need to not compress the index intermediate file when we generate it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2331) Turn off compression when generating
index intermediate results
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-2331:
-----------------------------
Status: Open (was: Patch Available)
Syed, you mixed up the .q.out files for bitmap vs compact (I got corresponding test failures).
> Turn off compression when generating index intermediate results
> ---------------------------------------------------------------
>
> Key: HIVE-2331
> URL: https://issues.apache.org/jira/browse/HIVE-2331
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2331.1.patch
>
>
> HiveIndexResult is not compression-aware, so for any index to work (regardless of compact/bitmap) we need to not compress the index intermediate file when we generate it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-2331) Turn off compression when generating
index intermediate results
Posted by "Syed S. Albiz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Syed S. Albiz reassigned HIVE-2331:
-----------------------------------
Assignee: Syed S. Albiz
> Turn off compression when generating index intermediate results
> ---------------------------------------------------------------
>
> Key: HIVE-2331
> URL: https://issues.apache.org/jira/browse/HIVE-2331
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
>
> HiveIndexResult is not compression-aware, so for any index to work (regardless of compact/bitmap) we need to not compress the index intermediate file when we generate it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira