You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/11 03:16:47 UTC
[GitHub] [iceberg] dungdm93 opened a new pull request #4091: Core: add FanoutEqualityDeleteWriter and FanoutPositionDeleteWriter
dungdm93 opened a new pull request #4091:
URL: https://github.com/apache/iceberg/pull/4091
Inspire from `ClusteredPositionDeleteWriter` and `ClusteredEqualityDeleteWriter`, this PR add 2 `FanoutWriter` that write delete files which could be used in streaming (e.g Flink)
Signed-off-by: Đặng Minh Dũng <du...@live.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary commented on pull request #4091: Core: add FanoutEqualityDeleteWriter and FanoutPositionDeleteWriter
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #4091:
URL: https://github.com/apache/iceberg/pull/4091#issuecomment-1041149875
@rdblue: Not sure about the `FanoutEqualityDeleteWriter`, but we are thinking about implementing deletes for low cardinality tables. `FanoutPositionDeleteWriter` might be useful there. Would that make sense there? That said we are only in the "scratching the surface" phase, so we might go into another direction when we start seriously working on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] dungdm93 commented on pull request #4091: Core: add FanoutEqualityDeleteWriter and FanoutPositionDeleteWriter
Posted by GitBox <gi...@apache.org>.
dungdm93 commented on pull request #4091:
URL: https://github.com/apache/iceberg/pull/4091#issuecomment-1035845859
cc @aokolnychyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4091: Core: add FanoutEqualityDeleteWriter and FanoutPositionDeleteWriter
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4091:
URL: https://github.com/apache/iceberg/pull/4091#issuecomment-1040572586
@dungdm93, are these needed? You said they "could be used" but we don't want to add classes unless they are actually going to be used by some engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] dungdm93 commented on pull request #4091: Core: add FanoutEqualityDeleteWriter and FanoutPositionDeleteWriter
Posted by GitBox <gi...@apache.org>.
dungdm93 commented on pull request #4091:
URL: https://github.com/apache/iceberg/pull/4091#issuecomment-1041324622
@rdblue @pvary actually, it's a part of #4132, let's go there for the discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4091: Core: add FanoutEqualityDeleteWriter and FanoutPositionDeleteWriter
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4091:
URL: https://github.com/apache/iceberg/pull/4091#issuecomment-1040572586
@dungdm93, are these needed? You said they "could be used" but we don't want to add classes unless they are actually going to be used by some engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org