[GitHub] mayankshriv commented on a change in pull request #3549: Cleaning data dir so URI construction works as expected

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #3549: Cleaning data dir so URI construction works as expected
URL: https://github.com/apache/incubator-pinot/pull/3549#discussion_r236459212
 
 

 ##########
 File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/api/resources/FileUploadPathProvider.java
 ##########
 @@ -134,4 +135,18 @@ public File getTmpUntarredPath() {
   public File getSchemasTmpDir() {
     return new File(_schemasTmpDirURI);
   }
+
+  /**
+   * Cleans dataDir by getting rid of unnecessary slashes at the end of dataDir. Needed so other URIs are constructed
+   * as expected.
+   * @param dataDir data directory of pinot segments
+   * @return cleaned data directory
+   */
+  private String cleanDataDir(String dataDir) {
 
 Review comment:
   The name seems to suggest data directory's content would be cleaned/removed. Why not just use existing utility functions such as trim()/strip() to do the same, instead of writing a new one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org