You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Charlie Carson <cc...@twitter.com> on 2014/01/16 23:08:30 UTC
.gitignore for automake files
Hey guys, is it good / bad / different if we were to add the files that
automake generates and to put them into appropriate .gitignore files and
check those in?
I'm new to mesos dev, so probably missing context, but wanted to double
check instead of just working around it for myself.
if it does make sense then I'd be happy to create the JIRA and initial CR.
thanks,
cc
Re: .gitignore for automake files
Posted by Tim St Clair <ts...@redhat.com>.
My typical answer to *this question is to do out-of-source builds where possible.
@Vinod
Patterns which a user wants Git to ignore in all situations (e.g., backup or temporary files generated by the user’s editor of choice) generally go into a file specified by core.excludesfile in the user’s ~/.gitconfig
----- Original Message -----
> From: "Vinod Kone" <vi...@gmail.com>
> To: "dev" <de...@mesos.apache.org>, dave@ischool.berkeley.edu
> Sent: Friday, January 17, 2014 1:05:39 PM
> Subject: Re: .gitignore for automake files
>
> My concern with adding .gitignore to the repo is that typically I have
> additional things I want to ignore that are specific to me (e.g., eclipse
> project files). Adding those to the .gitignore would should up in my git
> diff and git status if .gitignore is a tracked file.
>
>
> On Fri, Jan 17, 2014 at 10:25 AM, Dave Lester
> <da...@ischool.berkeley.edu>wrote:
>
> > Hi Ben,
> >
> > I see that you've already submitted this review
> > https://reviews.apache.org/r/17001/, but could answer my question above?
> >
> > It's possible that you didn't receive it because I sent it through my
> > Twitter email acct which is prone to being caught by email filters.
> >
> > Thanks,
> > Dave
> >
> >
> >
> > On Thu, Jan 16, 2014 at 4:31 PM, Dave Lester <dl...@twitter.com> wrote:
> >
> > > Hi Ben,
> > >
> > > Is there a previous thread you can point us to? I'd like to understand
> > the
> > > concern more. For most users, I think having a .gitignore file is the
> > > most-convenient way to manage your code in development. If people want to
> > > see ignored files, it's easy to run:
> > >
> > > git status --ignored
> > >
> > > What do you think?
> > >
> > > Dave
> > >
> > > On Thu, Jan 16, 2014 at 4:21 PM, Benjamin Hindman <
> > benh@eecs.berkeley.edu>wrote:
> > >
> > >> People have asked about this before. Some people don't want .gitignore
> > >> files because they like to see everything that's in their directories,
> > >> including generated files so they have a better idea of when something
> > was
> > >> supposed to get generated but didn't, etc.
> > >>
> > >> In the past people have simply added their own .gitignore (adding
> > >> '.gitignore' to it as well so it ignores itself). Someone once proposed
> > >> committing a .gitignore-template (or something similarly named) that a
> > >> developer can copy to .gitignore if they choose to (but this doesn't
> > force
> > >> people that don't want .gitignore to use it).
> > >>
> > >>
> > >> On Thu, Jan 16, 2014 at 3:11 PM, Dave Lester <dave@ischool.berkeley.edu
> > >> >wrote:
> > >>
> > >> > This makes sense to me.
> > >> >
> > >> >
> > >> > On Thu, Jan 16, 2014 at 2:08 PM, Charlie Carson <cc...@twitter.com>
> > >> > wrote:
> > >> >
> > >> > > Hey guys, is it good / bad / different if we were to add the files
> > >> that
> > >> > > automake generates and to put them into appropriate .gitignore files
> > >> and
> > >> > > check those in?
> > >> > >
> > >> > > I'm new to mesos dev, so probably missing context, but wanted to
> > >> double
> > >> > > check instead of just working around it for myself.
> > >> > >
> > >> > > if it does make sense then I'd be happy to create the JIRA and
> > initial
> > >> > CR.
> > >> > >
> > >> > > thanks,
> > >> > > cc
> > >> > >
> > >> >
> > >>
> > >
> > >
> > >
> > > --
> > > @davelester
> > > Open Source Advocate | Twitter, Inc
> > >
> >
>
--
Cheers,
Tim
Re: .gitignore for automake files
Posted by Charlie Carson <cc...@twitter.com>.
In theory, you can do that by have a personal .gitignore file specifed in
your git config. see the below from here<http://git-scm.com/docs/gitignore>.
(I say in theory b/c I haven't done it yet :-) )
-
Patterns which a user wants Git to ignore in all situations (e.g.,
backup or temporary files generated by the user's editor of choice)
generally go into a file specified by core.excludesfilein the user's
~/.gitconfig. Its default value is $XDG_CONFIG_HOME/git/ignore. If
$XDG_CONFIG_HOME is either not set or empty, $HOME/.config/git/ignore is
used instead.
cc
On Fri, Jan 17, 2014 at 11:05 AM, Vinod Kone <vi...@gmail.com> wrote:
> My concern with adding .gitignore to the repo is that typically I have
> additional things I want to ignore that are specific to me (e.g., eclipse
> project files). Adding those to the .gitignore would should up in my git
> diff and git status if .gitignore is a tracked file.
>
>
> On Fri, Jan 17, 2014 at 10:25 AM, Dave Lester <dave@ischool.berkeley.edu
> >wrote:
>
> > Hi Ben,
> >
> > I see that you've already submitted this review
> > https://reviews.apache.org/r/17001/, but could answer my question above?
> >
> > It's possible that you didn't receive it because I sent it through my
> > Twitter email acct which is prone to being caught by email filters.
> >
> > Thanks,
> > Dave
> >
> >
> >
> > On Thu, Jan 16, 2014 at 4:31 PM, Dave Lester <dl...@twitter.com>
> wrote:
> >
> > > Hi Ben,
> > >
> > > Is there a previous thread you can point us to? I'd like to understand
> > the
> > > concern more. For most users, I think having a .gitignore file is the
> > > most-convenient way to manage your code in development. If people want
> to
> > > see ignored files, it's easy to run:
> > >
> > > git status --ignored
> > >
> > > What do you think?
> > >
> > > Dave
> > >
> > > On Thu, Jan 16, 2014 at 4:21 PM, Benjamin Hindman <
> > benh@eecs.berkeley.edu>wrote:
> > >
> > >> People have asked about this before. Some people don't want .gitignore
> > >> files because they like to see everything that's in their directories,
> > >> including generated files so they have a better idea of when something
> > was
> > >> supposed to get generated but didn't, etc.
> > >>
> > >> In the past people have simply added their own .gitignore (adding
> > >> '.gitignore' to it as well so it ignores itself). Someone once
> proposed
> > >> committing a .gitignore-template (or something similarly named) that a
> > >> developer can copy to .gitignore if they choose to (but this doesn't
> > force
> > >> people that don't want .gitignore to use it).
> > >>
> > >>
> > >> On Thu, Jan 16, 2014 at 3:11 PM, Dave Lester <
> dave@ischool.berkeley.edu
> > >> >wrote:
> > >>
> > >> > This makes sense to me.
> > >> >
> > >> >
> > >> > On Thu, Jan 16, 2014 at 2:08 PM, Charlie Carson <
> ccarson@twitter.com>
> > >> > wrote:
> > >> >
> > >> > > Hey guys, is it good / bad / different if we were to add the files
> > >> that
> > >> > > automake generates and to put them into appropriate .gitignore
> files
> > >> and
> > >> > > check those in?
> > >> > >
> > >> > > I'm new to mesos dev, so probably missing context, but wanted to
> > >> double
> > >> > > check instead of just working around it for myself.
> > >> > >
> > >> > > if it does make sense then I'd be happy to create the JIRA and
> > initial
> > >> > CR.
> > >> > >
> > >> > > thanks,
> > >> > > cc
> > >> > >
> > >> >
> > >>
> > >
> > >
> > >
> > > --
> > > @davelester
> > > Open Source Advocate | Twitter, Inc
> > >
> >
>
Re: .gitignore for automake files
Posted by Vinod Kone <vi...@gmail.com>.
My concern with adding .gitignore to the repo is that typically I have
additional things I want to ignore that are specific to me (e.g., eclipse
project files). Adding those to the .gitignore would should up in my git
diff and git status if .gitignore is a tracked file.
On Fri, Jan 17, 2014 at 10:25 AM, Dave Lester <da...@ischool.berkeley.edu>wrote:
> Hi Ben,
>
> I see that you've already submitted this review
> https://reviews.apache.org/r/17001/, but could answer my question above?
>
> It's possible that you didn't receive it because I sent it through my
> Twitter email acct which is prone to being caught by email filters.
>
> Thanks,
> Dave
>
>
>
> On Thu, Jan 16, 2014 at 4:31 PM, Dave Lester <dl...@twitter.com> wrote:
>
> > Hi Ben,
> >
> > Is there a previous thread you can point us to? I'd like to understand
> the
> > concern more. For most users, I think having a .gitignore file is the
> > most-convenient way to manage your code in development. If people want to
> > see ignored files, it's easy to run:
> >
> > git status --ignored
> >
> > What do you think?
> >
> > Dave
> >
> > On Thu, Jan 16, 2014 at 4:21 PM, Benjamin Hindman <
> benh@eecs.berkeley.edu>wrote:
> >
> >> People have asked about this before. Some people don't want .gitignore
> >> files because they like to see everything that's in their directories,
> >> including generated files so they have a better idea of when something
> was
> >> supposed to get generated but didn't, etc.
> >>
> >> In the past people have simply added their own .gitignore (adding
> >> '.gitignore' to it as well so it ignores itself). Someone once proposed
> >> committing a .gitignore-template (or something similarly named) that a
> >> developer can copy to .gitignore if they choose to (but this doesn't
> force
> >> people that don't want .gitignore to use it).
> >>
> >>
> >> On Thu, Jan 16, 2014 at 3:11 PM, Dave Lester <dave@ischool.berkeley.edu
> >> >wrote:
> >>
> >> > This makes sense to me.
> >> >
> >> >
> >> > On Thu, Jan 16, 2014 at 2:08 PM, Charlie Carson <cc...@twitter.com>
> >> > wrote:
> >> >
> >> > > Hey guys, is it good / bad / different if we were to add the files
> >> that
> >> > > automake generates and to put them into appropriate .gitignore files
> >> and
> >> > > check those in?
> >> > >
> >> > > I'm new to mesos dev, so probably missing context, but wanted to
> >> double
> >> > > check instead of just working around it for myself.
> >> > >
> >> > > if it does make sense then I'd be happy to create the JIRA and
> initial
> >> > CR.
> >> > >
> >> > > thanks,
> >> > > cc
> >> > >
> >> >
> >>
> >
> >
> >
> > --
> > @davelester
> > Open Source Advocate | Twitter, Inc
> >
>
Re: .gitignore for automake files
Posted by Dave Lester <da...@ischool.berkeley.edu>.
Hi Ben,
I see that you've already submitted this review
https://reviews.apache.org/r/17001/, but could answer my question above?
It's possible that you didn't receive it because I sent it through my
Twitter email acct which is prone to being caught by email filters.
Thanks,
Dave
On Thu, Jan 16, 2014 at 4:31 PM, Dave Lester <dl...@twitter.com> wrote:
> Hi Ben,
>
> Is there a previous thread you can point us to? I'd like to understand the
> concern more. For most users, I think having a .gitignore file is the
> most-convenient way to manage your code in development. If people want to
> see ignored files, it's easy to run:
>
> git status --ignored
>
> What do you think?
>
> Dave
>
> On Thu, Jan 16, 2014 at 4:21 PM, Benjamin Hindman <be...@eecs.berkeley.edu>wrote:
>
>> People have asked about this before. Some people don't want .gitignore
>> files because they like to see everything that's in their directories,
>> including generated files so they have a better idea of when something was
>> supposed to get generated but didn't, etc.
>>
>> In the past people have simply added their own .gitignore (adding
>> '.gitignore' to it as well so it ignores itself). Someone once proposed
>> committing a .gitignore-template (or something similarly named) that a
>> developer can copy to .gitignore if they choose to (but this doesn't force
>> people that don't want .gitignore to use it).
>>
>>
>> On Thu, Jan 16, 2014 at 3:11 PM, Dave Lester <dave@ischool.berkeley.edu
>> >wrote:
>>
>> > This makes sense to me.
>> >
>> >
>> > On Thu, Jan 16, 2014 at 2:08 PM, Charlie Carson <cc...@twitter.com>
>> > wrote:
>> >
>> > > Hey guys, is it good / bad / different if we were to add the files
>> that
>> > > automake generates and to put them into appropriate .gitignore files
>> and
>> > > check those in?
>> > >
>> > > I'm new to mesos dev, so probably missing context, but wanted to
>> double
>> > > check instead of just working around it for myself.
>> > >
>> > > if it does make sense then I'd be happy to create the JIRA and initial
>> > CR.
>> > >
>> > > thanks,
>> > > cc
>> > >
>> >
>>
>
>
>
> --
> @davelester
> Open Source Advocate | Twitter, Inc
>
Re: .gitignore for automake files
Posted by Dave Lester <dl...@twitter.com>.
Hi Ben,
Is there a previous thread you can point us to? I'd like to understand the
concern more. For most users, I think having a .gitignore file is the
most-convenient way to manage your code in development. If people want to
see ignored files, it's easy to run:
git status --ignored
What do you think?
Dave
On Thu, Jan 16, 2014 at 4:21 PM, Benjamin Hindman <be...@eecs.berkeley.edu>wrote:
> People have asked about this before. Some people don't want .gitignore
> files because they like to see everything that's in their directories,
> including generated files so they have a better idea of when something was
> supposed to get generated but didn't, etc.
>
> In the past people have simply added their own .gitignore (adding
> '.gitignore' to it as well so it ignores itself). Someone once proposed
> committing a .gitignore-template (or something similarly named) that a
> developer can copy to .gitignore if they choose to (but this doesn't force
> people that don't want .gitignore to use it).
>
>
> On Thu, Jan 16, 2014 at 3:11 PM, Dave Lester <dave@ischool.berkeley.edu
> >wrote:
>
> > This makes sense to me.
> >
> >
> > On Thu, Jan 16, 2014 at 2:08 PM, Charlie Carson <cc...@twitter.com>
> > wrote:
> >
> > > Hey guys, is it good / bad / different if we were to add the files that
> > > automake generates and to put them into appropriate .gitignore files
> and
> > > check those in?
> > >
> > > I'm new to mesos dev, so probably missing context, but wanted to double
> > > check instead of just working around it for myself.
> > >
> > > if it does make sense then I'd be happy to create the JIRA and initial
> > CR.
> > >
> > > thanks,
> > > cc
> > >
> >
>
--
@davelester
Open Source Advocate | Twitter, Inc
Re: .gitignore for automake files
Posted by Charlie Carson <cc...@twitter.com>.
Ok - that sounds like the context I was missing.
do you want me to do send a CR for adding .gitignore-template (just a
single file in the root) path?
cc
On Thu, Jan 16, 2014 at 4:21 PM, Benjamin Hindman <be...@eecs.berkeley.edu>wrote:
> People have asked about this before. Some people don't want .gitignore
> files because they like to see everything that's in their directories,
> including generated files so they have a better idea of when something was
> supposed to get generated but didn't, etc.
>
> In the past people have simply added their own .gitignore (adding
> '.gitignore' to it as well so it ignores itself). Someone once proposed
> committing a .gitignore-template (or something similarly named) that a
> developer can copy to .gitignore if they choose to (but this doesn't force
> people that don't want .gitignore to use it).
>
>
> On Thu, Jan 16, 2014 at 3:11 PM, Dave Lester <dave@ischool.berkeley.edu
> >wrote:
>
> > This makes sense to me.
> >
> >
> > On Thu, Jan 16, 2014 at 2:08 PM, Charlie Carson <cc...@twitter.com>
> > wrote:
> >
> > > Hey guys, is it good / bad / different if we were to add the files that
> > > automake generates and to put them into appropriate .gitignore files
> and
> > > check those in?
> > >
> > > I'm new to mesos dev, so probably missing context, but wanted to double
> > > check instead of just working around it for myself.
> > >
> > > if it does make sense then I'd be happy to create the JIRA and initial
> > CR.
> > >
> > > thanks,
> > > cc
> > >
> >
>
Re: .gitignore for automake files
Posted by Benjamin Hindman <be...@eecs.berkeley.edu>.
People have asked about this before. Some people don't want .gitignore
files because they like to see everything that's in their directories,
including generated files so they have a better idea of when something was
supposed to get generated but didn't, etc.
In the past people have simply added their own .gitignore (adding
'.gitignore' to it as well so it ignores itself). Someone once proposed
committing a .gitignore-template (or something similarly named) that a
developer can copy to .gitignore if they choose to (but this doesn't force
people that don't want .gitignore to use it).
On Thu, Jan 16, 2014 at 3:11 PM, Dave Lester <da...@ischool.berkeley.edu>wrote:
> This makes sense to me.
>
>
> On Thu, Jan 16, 2014 at 2:08 PM, Charlie Carson <cc...@twitter.com>
> wrote:
>
> > Hey guys, is it good / bad / different if we were to add the files that
> > automake generates and to put them into appropriate .gitignore files and
> > check those in?
> >
> > I'm new to mesos dev, so probably missing context, but wanted to double
> > check instead of just working around it for myself.
> >
> > if it does make sense then I'd be happy to create the JIRA and initial
> CR.
> >
> > thanks,
> > cc
> >
>
Re: .gitignore for automake files
Posted by Dave Lester <da...@ischool.berkeley.edu>.
This makes sense to me.
On Thu, Jan 16, 2014 at 2:08 PM, Charlie Carson <cc...@twitter.com> wrote:
> Hey guys, is it good / bad / different if we were to add the files that
> automake generates and to put them into appropriate .gitignore files and
> check those in?
>
> I'm new to mesos dev, so probably missing context, but wanted to double
> check instead of just working around it for myself.
>
> if it does make sense then I'd be happy to create the JIRA and initial CR.
>
> thanks,
> cc
>