You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/07/07 15:27:24 UTC
[GitHub] [incubator-linkis] jackxu2011 opened a new pull request, #2436: refactor(linkis-scheduler): refactor some code
jackxu2011 opened a new pull request, #2436:
URL: https://github.com/apache/incubator-linkis/pull/2436
### What is the purpose of the change
refactor some code and add a some testCode
### Brief change log
(for example:)
- format some code
- refact [SchedulerEventState.scala](https://github.com/apache/incubator-linkis/compare/dev-1.2.0...jackxu2011:incubator-linkis:refact-linkis-scheduler?expand=1#diff-d9ba5737920d0f5affef0ef70d5a7f77fa11785a030e3d3520d62358d463307f) and add test code for isCompletedByStr
### Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- Anything that affects deployment: no
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: no
### Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #2436: refactor(linkis-scheduler): refactor some code
Posted by GitBox <gi...@apache.org>.
peacewong merged PR #2436:
URL: https://github.com/apache/incubator-linkis/pull/2436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2436: refactor(linkis-scheduler): refactor some code
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2436:
URL: https://github.com/apache/incubator-linkis/pull/2436#issuecomment-1177850270
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2436?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2436](https://codecov.io/gh/apache/incubator-linkis/pull/2436?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (641cbe6) into [dev-1.2.0](https://codecov.io/gh/apache/incubator-linkis/commit/523d2f747f41a3ff84a8827c0d7a86a684371448?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (523d2f7) will **decrease** coverage by `0.01%`.
> The diff coverage is `32.39%`.
```diff
@@ Coverage Diff @@
## dev-1.2.0 #2436 +/- ##
===============================================
- Coverage 18.11% 18.09% -0.02%
- Complexity 1093 1094 +1
===============================================
Files 597 597
Lines 17805 17788 -17
Branches 2660 2651 -9
===============================================
- Hits 3225 3219 -6
+ Misses 14145 14135 -10
+ Partials 435 434 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/linkis/common/listener/ListenerEventBus.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2436/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vbGlzdGVuZXIvTGlzdGVuZXJFdmVudEJ1cy5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [.../scala/org/apache/linkis/scheduler/Scheduler.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2436/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvU2NoZWR1bGVyLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/linkis/scheduler/executer/Executor.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2436/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvZXhlY3V0ZXIvRXhlY3V0b3Iuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...cheduler/queue/fifoqueue/FIFOConsumerManager.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2436/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvZmlmb3F1ZXVlL0ZJRk9Db25zdW1lck1hbmFnZXIuc2NhbGE=) | `79.31% <0.00%> (ø)` | |
| [...rg/apache/linkis/scheduler/AbstractScheduler.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2436/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvQWJzdHJhY3RTY2hlZHVsZXIuc2NhbGE=) | `42.30% <33.33%> (+3.84%)` | :arrow_up: |
| [...apache/linkis/scheduler/queue/SchedulerEvent.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2436/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvU2NoZWR1bGVyRXZlbnQuc2NhbGE=) | `52.94% <37.50%> (ø)` | |
| [...a/org/apache/linkis/scheduler/event/LogEvent.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2436/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvZXZlbnQvTG9nRXZlbnQuc2NhbGE=) | `50.00% <40.00%> (ø)` | |
| [...org/apache/linkis/scheduler/SchedulerContext.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2436/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvU2NoZWR1bGVyQ29udGV4dC5zY2FsYQ==) | `66.66% <50.00%> (ø)` | |
| [...e/linkis/scheduler/queue/SchedulerEventState.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2436/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvU2NoZWR1bGVyRXZlbnRTdGF0ZS5zY2FsYQ==) | `55.55% <50.00%> (+15.55%)` | :arrow_up: |
| [...eduler/queue/parallelqueue/ParallelScheduler.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2436/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvcGFyYWxsZWxxdWV1ZS9QYXJhbGxlbFNjaGVkdWxlci5zY2FsYQ==) | `85.71% <50.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-linkis/pull/2436/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2436?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2436?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [523d2f7...641cbe6](https://codecov.io/gh/apache/incubator-linkis/pull/2436?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org