You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/18 18:51:42 UTC

[GitHub] [spark] holdenk commented on a change in pull request #28864: [SPARK-32004][ALL] Drop references to slave

holdenk commented on a change in pull request #28864:
URL: https://github.com/apache/spark/pull/28864#discussion_r442433885



##########
File path: core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala
##########
@@ -102,8 +102,8 @@ private[deploy] object JsonProtocol {
     ("name" -> obj.desc.name) ~
     ("cores" -> obj.coresGranted) ~
     ("user" -> obj.desc.user) ~
-    ("memoryperslave" -> obj.desc.memoryPerExecutorMB) ~
-    ("resourcesperslave" -> obj.desc.resourceReqsPerExecutor
+    ("memoryperexecutor" -> obj.desc.memoryPerExecutorMB) ~

Review comment:
       Sure I think outputting both for the next while is ok. I'll add a comment in the Json protocol that says it's deprecated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org