[GitHub] [airflow] fredthomsen commented on pull request #18542: Allow ingress multiple hostnames w/diff secrets

[GitBox <gi...@apache.org>]

fredthomsen commented on pull request #18542:
URL: https://github.com/apache/airflow/pull/18542#issuecomment-962676508


   The use case is a company with a different hostnames based on internal network vs external network access. Now I haven't changed this to have different paths for different hosts here, although moving the hosts from an array of strings to an array of objects certainly allows the possibility of that in the future rather easily as you suggest. The only reason I didn't do this was because I didn't want to bloat the scope of the PR and I would think having different hostnames would be much more common than having differing paths as well. I certainly could add that into this PR if that was desired.
   
   ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
   On Wednesday, November 3rd, 2021 at 6:21 PM, Daniel Standish ***@***.***> wrote:
   
   > Hi ***@***.***(https://github.com/fredthomsen)
   >
   > Can you help me understand the use case for configuring multiple hosts?
   >
   > I noticed that we apply the same path to all hosts. But from looking at some examples, it appears that you can have a different path for each host, and moreover multiple paths for each host.
   >
   > So I'm wondering, if we're converting hosts to object, should we also fold into it not just tls but also path. And understanding the use case would be help me in thinking that through.
   >
   > Thanks
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, [view it on GitHub](https://github.com/apache/airflow/pull/18542#issuecomment-960239070), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAGW3QDQB7ZZXZMXI676ZBTUKG7XDANCNFSM5EZVY33Q).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org