You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2019/07/22 22:46:11 UTC

[GitHub] [metron] merrimanr commented on issue #1457: METRON-2176 Upgrade REST for HBase 2.0.2

merrimanr commented on issue #1457: METRON-2176 Upgrade REST for HBase 2.0.2
URL: https://github.com/apache/metron/pull/1457#issuecomment-513983166
 
 
   I ran through the test instructions and everything works as expected.  I also tested the admin user settings endpoints and those also work as expected.
   
   After seeing the `FakeHBaseClient` class in context, I agree there is no easy way to do this.  This approach is nice because we can use the same underlying classes for multiple tests.  Otherwise we would need to mock each test individually.  I'm am satisfied with the tradeoff you have chosen.  +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services