You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mikhail Loenko <ml...@gmail.com> on 2006/04/12 15:22:53 UTC

unstable NPE in the archive module

I'm seeing test errors in the archive module. I've heard that Stepan have seen
similar ones today in the morning.

The errors are unstable: Stepan could not reproduce it and I did not see them
previous time. So here they are:

Class tests.api.java.util.jar.ManifestTest

all tests error with:

N/A

java.lang.NullPointerException at
tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
at tests.api.java.util.jar.ManifestTest.setUp(ManifestTest.java:167)


Class tests.api.java.util.jar.JarInputStreamTest
9 tests error with

N/A

java.lang.NullPointerException at
tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
at tests.support.resource.Support_Resources.getURL(Support_Resources.java:42)
at tests.api.java.util.jar.JarInputStreamTest.setUp(JarInputStreamTest.java:352)

Ideas?

Thanks,
Mikhail

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Re: unstable NPE in the archive module

Posted by Mikhail Loenko <ml...@gmail.com>.
OK, as you like  :)

BTW, should I open a JIRA issue or refer to this mail thread in the commit
comment?

Thanks,
Mikhail

2006/4/12, George Harley <ge...@googlemail.com>:
> Hi Mikhail,
>
> Currently the tests for java.io.File are not enabled. I have fixed that
> locally and can see that there is a test already for this situation but
> the test itself is wrong since it expects the IOException to be thrown.
> I was just about to re-enable the File tests.
>
> I guess I am saying : I am happy to take care of the test part of this
> problem.
>
> Best regards,
> George
>
>
> Mikhail Loenko wrote:
> > OK, I'll fix and submit a test.
> >
> > 2006/4/12, Mark Hindess <ma...@googlemail.com>:
> >
> >> Yes.  That looks correct and matchs the RI behaviour for the case when
> >> the file exists and is a directory.
> >>
> >> -Mark.
> >>
> >>
> >> On 4/12/06, Mikhail Loenko <ml...@gmail.com> wrote:
> >>
> >>> I'd replace
> >>> case 1:
> >>>         return false;
> >>> case 3:
> >>>         throw new IOException(org.apache.harmony.luni.util.Msg.getString("K01c1"));
> >>> //$NON-NLS-1$
> >>>
> >>>
> >>> with
> >>> case 1:
> >>> case 3:
> >>>         return false;
> >>>
> >>>
> >>>
> >>> 2006/4/12, George Harley <ge...@googlemail.com>:
> >>>
> >>>> Thanks :-)
> >>>>
> >>>> Mikhail Loenko wrote:
> >>>>
> >>>>> WinXP
> >>>>>
> >>>>> 2006/4/12, George Harley <ge...@googlemail.com>:
> >>>>>
> >>>>>
> >>>>>> Hi Mikhail,
> >>>>>>
> >>>>>> What platform(s) are you seeing this on ?
> >>>>>>
> >>>>>> Best regards,
> >>>>>> George
> >>>>>>
> >>>>>>
> >>>>>> Mikhail Loenko wrote:
> >>>>>>
> >>>>>>
> >>>>>>> I'm seeing test errors in the archive module. I've heard that Stepan have seen
> >>>>>>> similar ones today in the morning.
> >>>>>>>
> >>>>>>> The errors are unstable: Stepan could not reproduce it and I did not see them
> >>>>>>> previous time. So here they are:
> >>>>>>>
> >>>>>>> Class tests.api.java.util.jar.ManifestTest
> >>>>>>>
> >>>>>>> all tests error with:
> >>>>>>>
> >>>>>>> N/A
> >>>>>>>
> >>>>>>> java.lang.NullPointerException at
> >>>>>>> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> >>>>>>> at tests.api.java.util.jar.ManifestTest.setUp(ManifestTest.java:167)
> >>>>>>>
> >>>>>>>
> >>>>>>> Class tests.api.java.util.jar.JarInputStreamTest
> >>>>>>> 9 tests error with
> >>>>>>>
> >>>>>>> N/A
> >>>>>>>
> >>>>>>> java.lang.NullPointerException at
> >>>>>>> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> >>>>>>> at tests.support.resource.Support_Resources.getURL(Support_Resources.java:42)
> >>>>>>> at tests.api.java.util.jar.JarInputStreamTest.setUp(JarInputStreamTest.java:352)
> >>>>>>>
> >>>>>>> Ideas?
> >>>>>>>
> >>>>>>> Thanks,
> >>>>>>> Mikhail
> >>>>>>>
> >>>>>>> ---------------------------------------------------------------------
> >>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >>>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>> ---------------------------------------------------------------------
> >>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>> ---------------------------------------------------------------------
> >>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>> ---------------------------------------------------------------------
> >>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>>>
> >>>>
> >>>>
> >>> ---------------------------------------------------------------------
> >>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>>
> >>>
> >>>
> >> --
> >> Mark Hindess <ma...@googlemail.com>
> >> IBM Java Technology Centre, UK.
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Re: unstable NPE in the archive module

Posted by George Harley <ge...@googlemail.com>.
Hi Mikhail,

Currently the tests for java.io.File are not enabled. I have fixed that 
locally and can see that there is a test already for this situation but 
the test itself is wrong since it expects the IOException to be thrown. 
I was just about to re-enable the File tests.

I guess I am saying : I am happy to take care of the test part of this 
problem.

Best regards,
George


Mikhail Loenko wrote:
> OK, I'll fix and submit a test.
>
> 2006/4/12, Mark Hindess <ma...@googlemail.com>:
>   
>> Yes.  That looks correct and matchs the RI behaviour for the case when
>> the file exists and is a directory.
>>
>> -Mark.
>>
>>
>> On 4/12/06, Mikhail Loenko <ml...@gmail.com> wrote:
>>     
>>> I'd replace
>>> case 1:
>>>         return false;
>>> case 3:
>>>         throw new IOException(org.apache.harmony.luni.util.Msg.getString("K01c1"));
>>> //$NON-NLS-1$
>>>
>>>
>>> with
>>> case 1:
>>> case 3:
>>>         return false;
>>>
>>>
>>>
>>> 2006/4/12, George Harley <ge...@googlemail.com>:
>>>       
>>>> Thanks :-)
>>>>
>>>> Mikhail Loenko wrote:
>>>>         
>>>>> WinXP
>>>>>
>>>>> 2006/4/12, George Harley <ge...@googlemail.com>:
>>>>>
>>>>>           
>>>>>> Hi Mikhail,
>>>>>>
>>>>>> What platform(s) are you seeing this on ?
>>>>>>
>>>>>> Best regards,
>>>>>> George
>>>>>>
>>>>>>
>>>>>> Mikhail Loenko wrote:
>>>>>>
>>>>>>             
>>>>>>> I'm seeing test errors in the archive module. I've heard that Stepan have seen
>>>>>>> similar ones today in the morning.
>>>>>>>
>>>>>>> The errors are unstable: Stepan could not reproduce it and I did not see them
>>>>>>> previous time. So here they are:
>>>>>>>
>>>>>>> Class tests.api.java.util.jar.ManifestTest
>>>>>>>
>>>>>>> all tests error with:
>>>>>>>
>>>>>>> N/A
>>>>>>>
>>>>>>> java.lang.NullPointerException at
>>>>>>> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
>>>>>>> at tests.api.java.util.jar.ManifestTest.setUp(ManifestTest.java:167)
>>>>>>>
>>>>>>>
>>>>>>> Class tests.api.java.util.jar.JarInputStreamTest
>>>>>>> 9 tests error with
>>>>>>>
>>>>>>> N/A
>>>>>>>
>>>>>>> java.lang.NullPointerException at
>>>>>>> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
>>>>>>> at tests.support.resource.Support_Resources.getURL(Support_Resources.java:42)
>>>>>>> at tests.api.java.util.jar.JarInputStreamTest.setUp(JarInputStreamTest.java:352)
>>>>>>>
>>>>>>> Ideas?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Mikhail
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>>> ---------------------------------------------------------------------
>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>>>
>>>>>>
>>>>>>
>>>>>>             
>>>>> ---------------------------------------------------------------------
>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>>
>>>>>
>>>>>
>>>>>           
>>>> ---------------------------------------------------------------------
>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>
>>>>
>>>>         
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>>
>>>       
>> --
>> Mark Hindess <ma...@googlemail.com>
>> IBM Java Technology Centre, UK.
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>>     
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
>   


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Re: unstable NPE in the archive module

Posted by Mikhail Loenko <ml...@gmail.com>.
OK, I'll fix and submit a test.

2006/4/12, Mark Hindess <ma...@googlemail.com>:
> Yes.  That looks correct and matchs the RI behaviour for the case when
> the file exists and is a directory.
>
> -Mark.
>
>
> On 4/12/06, Mikhail Loenko <ml...@gmail.com> wrote:
> > I'd replace
> > case 1:
> >         return false;
> > case 3:
> >         throw new IOException(org.apache.harmony.luni.util.Msg.getString("K01c1"));
> > //$NON-NLS-1$
> >
> >
> > with
> > case 1:
> > case 3:
> >         return false;
> >
> >
> >
> > 2006/4/12, George Harley <ge...@googlemail.com>:
> > >
> > > Thanks :-)
> > >
> > > Mikhail Loenko wrote:
> > > > WinXP
> > > >
> > > > 2006/4/12, George Harley <ge...@googlemail.com>:
> > > >
> > > >> Hi Mikhail,
> > > >>
> > > >> What platform(s) are you seeing this on ?
> > > >>
> > > >> Best regards,
> > > >> George
> > > >>
> > > >>
> > > >> Mikhail Loenko wrote:
> > > >>
> > > >>> I'm seeing test errors in the archive module. I've heard that Stepan have seen
> > > >>> similar ones today in the morning.
> > > >>>
> > > >>> The errors are unstable: Stepan could not reproduce it and I did not see them
> > > >>> previous time. So here they are:
> > > >>>
> > > >>> Class tests.api.java.util.jar.ManifestTest
> > > >>>
> > > >>> all tests error with:
> > > >>>
> > > >>> N/A
> > > >>>
> > > >>> java.lang.NullPointerException at
> > > >>> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> > > >>> at tests.api.java.util.jar.ManifestTest.setUp(ManifestTest.java:167)
> > > >>>
> > > >>>
> > > >>> Class tests.api.java.util.jar.JarInputStreamTest
> > > >>> 9 tests error with
> > > >>>
> > > >>> N/A
> > > >>>
> > > >>> java.lang.NullPointerException at
> > > >>> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> > > >>> at tests.support.resource.Support_Resources.getURL(Support_Resources.java:42)
> > > >>> at tests.api.java.util.jar.JarInputStreamTest.setUp(JarInputStreamTest.java:352)
> > > >>>
> > > >>> Ideas?
> > > >>>
> > > >>> Thanks,
> > > >>> Mikhail
> > > >>>
> > > >>> ---------------------------------------------------------------------
> > > >>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > >>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > >>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >> ---------------------------------------------------------------------
> > > >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > >>
> > > >>
> > > >>
> > > >
> > > > ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > >
> > > >
> > > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Mark Hindess <ma...@googlemail.com>
> IBM Java Technology Centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Re: unstable NPE in the archive module

Posted by Mark Hindess <ma...@googlemail.com>.
Yes.  That looks correct and matchs the RI behaviour for the case when
the file exists and is a directory.

-Mark.


On 4/12/06, Mikhail Loenko <ml...@gmail.com> wrote:
> I'd replace
> case 1:
>         return false;
> case 3:
>         throw new IOException(org.apache.harmony.luni.util.Msg.getString("K01c1"));
> //$NON-NLS-1$
>
>
> with
> case 1:
> case 3:
>         return false;
>
>
>
> 2006/4/12, George Harley <ge...@googlemail.com>:
> >
> > Thanks :-)
> >
> > Mikhail Loenko wrote:
> > > WinXP
> > >
> > > 2006/4/12, George Harley <ge...@googlemail.com>:
> > >
> > >> Hi Mikhail,
> > >>
> > >> What platform(s) are you seeing this on ?
> > >>
> > >> Best regards,
> > >> George
> > >>
> > >>
> > >> Mikhail Loenko wrote:
> > >>
> > >>> I'm seeing test errors in the archive module. I've heard that Stepan have seen
> > >>> similar ones today in the morning.
> > >>>
> > >>> The errors are unstable: Stepan could not reproduce it and I did not see them
> > >>> previous time. So here they are:
> > >>>
> > >>> Class tests.api.java.util.jar.ManifestTest
> > >>>
> > >>> all tests error with:
> > >>>
> > >>> N/A
> > >>>
> > >>> java.lang.NullPointerException at
> > >>> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> > >>> at tests.api.java.util.jar.ManifestTest.setUp(ManifestTest.java:167)
> > >>>
> > >>>
> > >>> Class tests.api.java.util.jar.JarInputStreamTest
> > >>> 9 tests error with
> > >>>
> > >>> N/A
> > >>>
> > >>> java.lang.NullPointerException at
> > >>> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> > >>> at tests.support.resource.Support_Resources.getURL(Support_Resources.java:42)
> > >>> at tests.api.java.util.jar.JarInputStreamTest.setUp(JarInputStreamTest.java:352)
> > >>>
> > >>> Ideas?
> > >>>
> > >>> Thanks,
> > >>> Mikhail
> > >>>
> > >>> ---------------------------------------------------------------------
> > >>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > >>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > >>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >>>
> > >>>
> > >>>
> > >>>
> > >> ---------------------------------------------------------------------
> > >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >>
> > >>
> > >>
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> > >
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


--
Mark Hindess <ma...@googlemail.com>
IBM Java Technology Centre, UK.

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Re: unstable NPE in the archive module

Posted by Mikhail Loenko <ml...@gmail.com>.
I'd replace
case 1:
	return false;
case 3:
	throw new IOException(org.apache.harmony.luni.util.Msg.getString("K01c1"));
//$NON-NLS-1$


with
case 1:
case 3:
	return false;



2006/4/12, George Harley <ge...@googlemail.com>:
>
> Thanks :-)
>
> Mikhail Loenko wrote:
> > WinXP
> >
> > 2006/4/12, George Harley <ge...@googlemail.com>:
> >
> >> Hi Mikhail,
> >>
> >> What platform(s) are you seeing this on ?
> >>
> >> Best regards,
> >> George
> >>
> >>
> >> Mikhail Loenko wrote:
> >>
> >>> I'm seeing test errors in the archive module. I've heard that Stepan have seen
> >>> similar ones today in the morning.
> >>>
> >>> The errors are unstable: Stepan could not reproduce it and I did not see them
> >>> previous time. So here they are:
> >>>
> >>> Class tests.api.java.util.jar.ManifestTest
> >>>
> >>> all tests error with:
> >>>
> >>> N/A
> >>>
> >>> java.lang.NullPointerException at
> >>> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> >>> at tests.api.java.util.jar.ManifestTest.setUp(ManifestTest.java:167)
> >>>
> >>>
> >>> Class tests.api.java.util.jar.JarInputStreamTest
> >>> 9 tests error with
> >>>
> >>> N/A
> >>>
> >>> java.lang.NullPointerException at
> >>> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> >>> at tests.support.resource.Support_Resources.getURL(Support_Resources.java:42)
> >>> at tests.api.java.util.jar.JarInputStreamTest.setUp(JarInputStreamTest.java:352)
> >>>
> >>> Ideas?
> >>>
> >>> Thanks,
> >>> Mikhail
> >>>
> >>> ---------------------------------------------------------------------
> >>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>>
> >>>
> >>>
> >>>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Re: unstable NPE in the archive module

Posted by George Harley <ge...@googlemail.com>.
Thanks :-)

Mikhail Loenko wrote:
> WinXP
>
> 2006/4/12, George Harley <ge...@googlemail.com>:
>   
>> Hi Mikhail,
>>
>> What platform(s) are you seeing this on ?
>>
>> Best regards,
>> George
>>
>>
>> Mikhail Loenko wrote:
>>     
>>> I'm seeing test errors in the archive module. I've heard that Stepan have seen
>>> similar ones today in the morning.
>>>
>>> The errors are unstable: Stepan could not reproduce it and I did not see them
>>> previous time. So here they are:
>>>
>>> Class tests.api.java.util.jar.ManifestTest
>>>
>>> all tests error with:
>>>
>>> N/A
>>>
>>> java.lang.NullPointerException at
>>> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
>>> at tests.api.java.util.jar.ManifestTest.setUp(ManifestTest.java:167)
>>>
>>>
>>> Class tests.api.java.util.jar.JarInputStreamTest
>>> 9 tests error with
>>>
>>> N/A
>>>
>>> java.lang.NullPointerException at
>>> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
>>> at tests.support.resource.Support_Resources.getURL(Support_Resources.java:42)
>>> at tests.api.java.util.jar.JarInputStreamTest.setUp(JarInputStreamTest.java:352)
>>>
>>> Ideas?
>>>
>>> Thanks,
>>> Mikhail
>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>>
>>>
>>>       
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>>     
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
>   


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Re: unstable NPE in the archive module

Posted by Mikhail Loenko <ml...@gmail.com>.
WinXP

2006/4/12, George Harley <ge...@googlemail.com>:
> Hi Mikhail,
>
> What platform(s) are you seeing this on ?
>
> Best regards,
> George
>
>
> Mikhail Loenko wrote:
> > I'm seeing test errors in the archive module. I've heard that Stepan have seen
> > similar ones today in the morning.
> >
> > The errors are unstable: Stepan could not reproduce it and I did not see them
> > previous time. So here they are:
> >
> > Class tests.api.java.util.jar.ManifestTest
> >
> > all tests error with:
> >
> > N/A
> >
> > java.lang.NullPointerException at
> > tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> > at tests.api.java.util.jar.ManifestTest.setUp(ManifestTest.java:167)
> >
> >
> > Class tests.api.java.util.jar.JarInputStreamTest
> > 9 tests error with
> >
> > N/A
> >
> > java.lang.NullPointerException at
> > tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> > at tests.support.resource.Support_Resources.getURL(Support_Resources.java:42)
> > at tests.api.java.util.jar.JarInputStreamTest.setUp(JarInputStreamTest.java:352)
> >
> > Ideas?
> >
> > Thanks,
> > Mikhail
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Re: unstable NPE in the archive module

Posted by George Harley <ge...@googlemail.com>.
Hi Mikhail,

What platform(s) are you seeing this on ?

Best regards,
George


Mikhail Loenko wrote:
> I'm seeing test errors in the archive module. I've heard that Stepan have seen
> similar ones today in the morning.
>
> The errors are unstable: Stepan could not reproduce it and I did not see them
> previous time. So here they are:
>
> Class tests.api.java.util.jar.ManifestTest
>
> all tests error with:
>
> N/A
>
> java.lang.NullPointerException at
> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> at tests.api.java.util.jar.ManifestTest.setUp(ManifestTest.java:167)
>
>
> Class tests.api.java.util.jar.JarInputStreamTest
> 9 tests error with
>
> N/A
>
> java.lang.NullPointerException at
> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> at tests.support.resource.Support_Resources.getURL(Support_Resources.java:42)
> at tests.api.java.util.jar.JarInputStreamTest.setUp(JarInputStreamTest.java:352)
>
> Ideas?
>
> Thanks,
> Mikhail
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
>   


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Re: unstable NPE in the archive module

Posted by Mikhail Loenko <ml...@gmail.com>.
More of stack trace:

java.io.IOException: File is a Directory
	at java.io.File.createNewFile(File.java:1035)
	at java.io.File.createTempFile(File.java:1089)
	at tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:66)
	at tests.support.resource.Support_Resources.getURL(Support_Resources.java:42)
	at tests.api.java.util.jar.JarInputStreamTest.setUp(JarInputStreamTest.java:352)
	at junit.framework.TestCase.runBare(TestCase.java:125)
	at junit.framework.TestResult$1.protect(TestResult.java:106)
	at junit.framework.TestResult.runProtected(TestResult.java:124)
	at junit.framework.TestResult.run(TestResult.java:109)
	at junit.framework.TestCase.run(TestCase.java:118)
	at junit.framework.TestSuite.runTest(TestSuite.java:208)
	at junit.framework.TestSuite.run(TestSuite.java:203)
	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:297)
	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:672)
	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:546)


So I see two bugs here. The first one in the implementation of java.io.File -
according to the spec createNewFile should not throw exception if file
or directory exists.

The second bug is in Support_Resources - new file might appear between
the following lines:

	folder = File.createTempFile("hyts_resources", "", null);
	folder.delete();
	folder.mkdirs();
So this should be in syncrhonized block

Can IO guys please comment?

Thanks,
Mikhail

2006/4/12, Mikhail Loenko <ml...@gmail.com>:
> I'm seeing test errors in the archive module. I've heard that Stepan have seen
> similar ones today in the morning.
>
> The errors are unstable: Stepan could not reproduce it and I did not see them
> previous time. So here they are:
>
> Class tests.api.java.util.jar.ManifestTest
>
> all tests error with:
>
> N/A
>
> java.lang.NullPointerException at
> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> at tests.api.java.util.jar.ManifestTest.setUp(ManifestTest.java:167)
>
>
> Class tests.api.java.util.jar.JarInputStreamTest
> 9 tests error with
>
> N/A
>
> java.lang.NullPointerException at
> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> at tests.support.resource.Support_Resources.getURL(Support_Resources.java:42)
> at tests.api.java.util.jar.JarInputStreamTest.setUp(JarInputStreamTest.java:352)
>
> Ideas?
>
> Thanks,
> Mikhail
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org