You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by brkyvz <gi...@git.apache.org> on 2017/05/01 23:47:13 UTC

[GitHub] spark pull request #17826: [SPARK-20549] 'java.io.CharConversionException: I...

GitHub user brkyvz opened a pull request:

    https://github.com/apache/spark/pull/17826

    [SPARK-20549] 'java.io.CharConversionException: Invalid UTF-32' in JsonToStructs

    ## What changes were proposed in this pull request?
    
    A fix for the same problem was made in #17693 but ignored `JsonToStructs`. This PR uses the same fix for `JsonToStructs`.
    
    ## How was this patch tested?
    
    Regression test

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brkyvz/spark SPARK-20549

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17826.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17826
    
----
commit 3d8559c4ce59bc033d12f078fa39b497ed53f57f
Author: Burak Yavuz <br...@gmail.com>
Date:   2017-05-01T23:42:05Z

    ready for review

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17826: [SPARK-20549] 'java.io.CharConversionException: Invalid ...

Posted by cloud-fan <gi...@git.apache.org>.

Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/17826
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17826: [SPARK-20549] 'java.io.CharConversionException: Invalid ...

Posted by cloud-fan <gi...@git.apache.org>.

Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/17826
  
    I'm not sure what's the semantic of `xpath_string`...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17826: [SPARK-20549] 'java.io.CharConversionException: Invalid ...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/17826
  
    Maybe let me leave this out for now until someone raises an issue about this again. Thank you for your response @cloud-fan.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17826: [SPARK-20549] 'java.io.CharConversionException: Invalid ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17826
  
    **[Test build #76366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76366/testReport)** for PR 17826 at commit [`6d59636`](https://github.com/apache/spark/commit/6d59636868c32dd63489c5c02282c890e4cd7e5d).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17826: [SPARK-20549] 'java.io.CharConversionException: Invalid ...

Posted by cloud-fan <gi...@git.apache.org>.

Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/17826
  
    thanks, merging to master/2.2!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17826: [SPARK-20549] 'java.io.CharConversionException: Invalid ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17826
  
    **[Test build #76366 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76366/testReport)** for PR 17826 at commit [`6d59636`](https://github.com/apache/spark/commit/6d59636868c32dd63489c5c02282c890e4cd7e5d).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17826: [SPARK-20549] 'java.io.CharConversionException: Invalid ...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17826
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17826: [SPARK-20549] 'java.io.CharConversionException: Invalid ...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/17826
  
    Hi @cloud-fan and @brkyvz, just while checking related issues with it just for my curiosity, I just realised that we are throwing an exception in XML related expressions as below:
    
    ```scala
    scala> sql("SELECT xpath_string('<a><b>b</b><c>cc</c></','a/c')").show()
    ...
    java.lang.RuntimeException: Invalid XML document: org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 23; XML document structures must start and end within the same entity.
    <a><b>b</b><c>cc</c></
      at org.apache.spark.sql.catalyst.expressions.xml.UDFXPathUtil.eval(UDFXPathUtil.java:72)
      at org.apache.spark.sql.catalyst.expressions.xml.UDFXPathUtil.evalString(UDFXPathUtil.java:81)
      at org.apache.spark.sql.catalyst.expressions.xml.XPathString.nullSafeEval(xpath.scala:186)
    ...
    ```
    
    Should we fix these expressions too or just leave them out for now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #17826: [SPARK-20549] 'java.io.CharConversionException: Invalid ...

Posted by brkyvz <gi...@git.apache.org>.

Github user brkyvz commented on the issue:

    https://github.com/apache/spark/pull/17826
  
    cc @hvanhovell @cloud-fan @ewasserman


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org