You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2024/09/20 07:49:00 UTC

[jira] [Commented] (HADOOP-19261) Support force close a DomainSocket for server service

    [ https://issues.apache.org/jira/browse/HADOOP-19261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883183#comment-17883183 ] 

ASF GitHub Bot commented on HADOOP-19261:
-----------------------------------------

ChenSammi opened a new pull request, #7057:
URL: https://github.com/apache/hadoop/pull/7057

   ### Description of PR
   https://issues.apache.org/jira/browse/HADOOP-19261
   
   Currently the DomainSocket#close will check the reference count to be 0 before it goes on to close the socket. In server service case, server calls DomainSocket#listen will add 1 to the reference count. When trying to close the server socket which is blocked by accept, the close call will doing endless count > 0 check, which prevent the server socket to be closed. 
   
   ### How was this patch tested?
   Improved TestDomainSocket to test the new code.  
   Before the patch, most of tests in TestDomainSocket will take 3 minutes and end up like this 
   
   ![Screenshot 2024-09-20 at 15 07 50](https://github.com/user-attachments/assets/f94bee40-7e41-4b48-afde-7e0a745257bc)
   
   With the patch applied,  here is the execution result of TestDomainSocket
   ![Screenshot 2024-09-20 at 15 30 01](https://github.com/user-attachments/assets/2493c383-6fb8-43cf-8cdd-d3aa8d2b0a9f)
   
   
   
   
   
   
   
   




> Support force close a DomainSocket for server service
> -----------------------------------------------------
>
>                 Key: HADOOP-19261
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19261
>             Project: Hadoop Common
>          Issue Type: New Feature
>            Reporter: Sammi Chen
>            Assignee: Sammi Chen
>            Priority: Major
>
> Currently the DomainSocket#close will check the reference count to be 0 before it goes on to close the socket. In server service case, server calls DomainSocket#listen will add 1 to the reference count. When trying to close the server socket which is blocked by accept, the close call will doing endless count > 0 check, which prevent the server socket to be closed. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org