[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #9941: [Enhancement] Column prune for olap scan node

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on code in PR #9941:
URL: https://github.com/apache/incubator-doris/pull/9941#discussion_r887773039


##########
fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java:
##########
@@ -984,4 +984,17 @@ public String toString() {
         sb.append("\n").append(getNodeExplainString("", TExplainLevel.BRIEF));
         return sb.toString();
     }
+
+    /**
+     * Used to append some common explains to output
+     */
+    protected void appendCommonExplainString(String detailPrefix, StringBuilder output) {

Review Comment:
   It seems that there is already a getExplainString in the plan node for common string output.



##########
fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java:
##########
@@ -941,4 +943,17 @@ public DataPartition constructInputPartitionByDistributionInfo() throws UserExce
             return DataPartition.RANDOM;
         }
     }
+
+    @Override
+    public void initOutputSlotIds(Set<SlotId> requiredSlotIdSet, Analyzer analyzer) throws NotImplementedException {

Review Comment:
   Although fe calculates the output slot of the scan node, if be does not make any changes, the function of project cannot be realized.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org