[jira] [Commented] (HIVE-1735) Extend Explode UDTF to handle Maps

["jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13076108#comment-13076108 ] 

jiraposter@reviews.apache.org commented on HIVE-1735:
-----------------------------------------------------



bq.  On 2011-01-25 13:19:29, Carl Steinbach wrote:
bq.  > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFExplode.java, line 106
bq.  > <https://reviews.apache.org/r/354/diff/1/?file=10207#file10207line106>
bq.  >
bq.  >     Under what conditions are map and array null? Is this code path exercised by any of the tests? Just trying to wrap my head around what this means. I'd prefer to see this changed to an assertion if map and array should never be null.

explode_null.q is failing because of this assert change. So, this is needed to handle if the map or array object is null in some of the rows. 


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/354/#review154
-----------------------------------------------------------


On 2011-01-31 21:19:47, Jonathan Natkins wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/354/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-01-31 21:19:47)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Review request for HIVE-1735.
bq.  
bq.  
bq.  This addresses bug HIVE-1735.
bq.      https://issues.apache.org/jira/browse/HIVE-1735
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFExplode.java d1e7def 
bq.    ql/src/test/queries/clientnegative/udtf_explode_not_supported1.q PRE-CREATION 
bq.    ql/src/test/queries/clientnegative/udtf_explode_not_supported2.q PRE-CREATION 
bq.    ql/src/test/queries/clientnegative/udtf_explode_not_supported3.q PRE-CREATION 
bq.    ql/src/test/queries/clientnegative/udtf_explode_not_supported4.q PRE-CREATION 
bq.    ql/src/test/queries/clientpositive/udf_explode.q f5c0323 
bq.    ql/src/test/queries/clientpositive/udtf_explode.q f5c0323 
bq.    ql/src/test/results/clientnegative/udtf_explode_not_supported1.q.out PRE-CREATION 
bq.    ql/src/test/results/clientnegative/udtf_explode_not_supported2.q.out PRE-CREATION 
bq.    ql/src/test/results/clientnegative/udtf_explode_not_supported3.q.out PRE-CREATION 
bq.    ql/src/test/results/clientnegative/udtf_explode_not_supported4.q.out PRE-CREATION 
bq.    ql/src/test/results/clientpositive/udf_explode.q.out 511732f 
bq.    ql/src/test/results/clientpositive/udtf_explode.q.out 6702c3f 
bq.  
bq.  Diff: https://reviews.apache.org/r/354/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Manual and automated testing
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jonathan
bq.  
bq.



> Extend Explode UDTF to handle Maps
> ----------------------------------
>
>                 Key: HIVE-1735
>                 URL: https://issues.apache.org/jira/browse/HIVE-1735
>             Project: Hive
>          Issue Type: New Feature
>          Components: UDF
>            Reporter: Carl Steinbach
>            Assignee: Jonathan Natkins
>         Attachments: HIVE-1735.1.patch, HIVE-1735.2.patch.txt, HIVE-1735.2.patch.txt
>
>
> The explode() UDTF currently only accepts arrays as input. We should modify it
> so that it can also handle map inputs, in which case it will output two columns
> corresponding to the key and value fields.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira