[jira] Commented: (MAPREDUCE-1758) Building blocks for the herriot test cases

["Iyappan Srinivasan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883418#action_12883418 ] 

Iyappan Srinivasan commented on MAPREDUCE-1758:
-----------------------------------------------

Some comments on the new patch:

1) isTaskStopped method:

a) If Task is in UNASSIGNED state, still this method will return false. I think, the method should wait for it to get assigned, finish running and then return true.

b) TaskID tID should be checked for null in the beginning of the method, before passing it as a parameter to a method.

2) isJobStopped method:

a) JobID id parameter might be null. Check for it before passing it to a  method.

b) jInfo can be returned null in jInfo = getProxy().getJobInfo(id);
 So , jInfo.getStatus() can be done as "if (jInfo ! = null && jInfo.getStatus().isJobComplete())"

3) Formatting  issue at: 
+          FinishTaskControlAction action = new FinishTaskControlAction(TaskID
+     .    downgrade(taskInfoRemaining.getTaskID()));

4) +    Assert.assertTrue("Task did not stop "+tID,ttClientIns.isTaskStopped(tID));
 - Spacing between + and also spacing between comma.

> Building blocks for the  herriot test cases 
> --------------------------------------------
>
>                 Key: MAPREDUCE-1758
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1758
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>            Reporter: Balaji Rajagopalan
>            Assignee: Balaji Rajagopalan
>            Priority: Minor
>         Attachments: bb_patch.txt, bb_patch_1.txt
>
>
> There is so much commonality in the test cases that we are writing, so it is pertinent to create reusable code. The common methods will be added to herriot framework. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.