You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yx9o (via GitHub)" <gi...@apache.org> on 2026/08/01 12:34:11 UTC
[PR] [Studio] feat: support managing ACL user cluster scope [rocketmq-dashboard]
yx9o opened a new pull request, #741:
URL: https://github.com/apache/rocketmq-dashboard/pull/741
## What is the purpose of the change
Allow users to configure the associated cluster scope when creating or editing ACL users instead of using a hardcoded cluster.
## Brief changelog
- Add a multi-value cluster field to the ACL user form
- Support adding, replacing, and clearing associated clusters
- Submit the configured cluster scope when creating or updating users
- Add regression tests for creating and editing ACL user cluster scopes
## Verifying this change
- `npm test -- --run src/pages/instance/__tests__/AclPage.test.tsx`
- `npm test -- --reporter=dot`
- `npm run lint`
- `npm run build`
- `npx prettier --check src/pages/instance/acl.tsx src/pages/instance/__tests__/AclPage.test.tsx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Studio] feat: support managing ACL user cluster scope [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #741:
URL: https://github.com/apache/rocketmq-dashboard/pull/741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Studio] feat: support managing ACL user cluster scope [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #741:
URL: https://github.com/apache/rocketmq-dashboard/pull/741#issuecomment-5153342795
## PR Review for #741: [Studio] feat: support managing ACL user cluster scope
### Summary
This PR modifies 2 file(s) with +75/-4 lines changed.
### Changed Files
- web/src/pages/instance/__tests__/AclPage.test.tsx
- web/src/pages/instance/acl.tsx
### Observations
- PR author: @yx9o
- Diff size: 5203 characters
- 77 additions, 6 deletions in diff
### ⚠️ Warning
Potential sensitive data exposure detected in diff. Please verify no credentials are hardcoded.
### Next Steps
A detailed code-level review requires the code engine. This is a structural overview only.
Please verify correctness, thread safety, and backward compatibility manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org