You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/24 07:46:37 UTC
[GitHub] [airflow] jhtimmins opened a new pull request #21784: Add tags inside try block.
jhtimmins opened a new pull request #21784:
URL: https://github.com/apache/airflow/pull/21784
Forces the Sentry customization to occur in the scope in which tags are called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] masterlittle commented on pull request #21784: Add tags inside try block.
Posted by GitBox <gi...@apache.org>.
masterlittle commented on pull request #21784:
URL: https://github.com/apache/airflow/pull/21784#issuecomment-1078655603
Any idea in which release this is gonna be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21784: Add tags inside try block.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21784:
URL: https://github.com/apache/airflow/pull/21784#issuecomment-1079968659
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21784: Add tags inside try block.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21784:
URL: https://github.com/apache/airflow/pull/21784#issuecomment-1079968763
> Do we need to/can we add tests for this to prevent regression?
I tihnk it's not worth to find a clever way to test it ? (But @jhtimmins maybe you can find one?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #21784: Add tags inside try block.
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #21784:
URL: https://github.com/apache/airflow/pull/21784#issuecomment-1051088319
Do we need to/can we add tests for this to prevent regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21784: Add tags inside try block.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21784:
URL: https://github.com/apache/airflow/pull/21784#issuecomment-1079968829
> Any idea in which release this is gonna be merged?
We are just voting on 2.2.5 so most likely in 2.3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org